Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Issue 2689213015: Remove SafePointScope from WorkerThread (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, shimazu+worker_chromium.org, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SafePointScope from WorkerThread Now that an Oilpan GC runs per thread, the SafePointScope should not be needed. BUG=671856 Review-Url: https://codereview.chromium.org/2689213015 Cr-Commit-Position: refs/heads/master@{#451313} Committed: https://chromium.googlesource.com/chromium/src/+/6e516a63e0c656af33c92ce1ecad182fb6626bff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M third_party/WebKit/Source/core/workers/WorkerThread.cpp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
haraken
PTAL
3 years, 10 months ago (2017-02-17 10:56:44 UTC) #2
sof
lgtm
3 years, 10 months ago (2017-02-17 10:59:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689213015/1
3 years, 10 months ago (2017-02-17 11:29:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/121448)
3 years, 10 months ago (2017-02-17 12:13:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689213015/1
3 years, 10 months ago (2017-02-17 13:37:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/121489)
3 years, 10 months ago (2017-02-17 15:19:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689213015/1
3 years, 10 months ago (2017-02-17 15:20:48 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-17 16:04:45 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6e516a63e0c656af33c92ce1ecad...

Powered by Google App Engine
This is Rietveld 408576698