DevTools: Add icons to performance pane tabs.

DevTools: Add icons to performance pane tabs.

BUG=693238
Review-Url: https://codereview.chromium.org/2689213012
Cr-Commit-Position: refs/heads/master@{#451321}
Committed: https://chromium.googlesource.com/chromium/src/+/8376a0c3554ffb329e74e899f4277f7a80b52448

[alph, 2017-02-16 22:47:23]

alph@chromium.org changed reviewers:
+ caseq@chromium.org, kozyatinskiy@chromium.org, paulirish@chromium.org

[paulirish, 2017-02-17 00:50:06]

I like the icons. It adds value to the view behind each. lgtm

I am still hesitant about the overall move to tabs, but think that even if we
revert that change, we'd keep the icons.

[alph, 2017-02-17 00:52:31]

On 2017/02/17 00:50:06, paulirish wrote:
> I like the icons. It adds value to the view behind each. lgtm
> 
> I am still hesitant about the overall move to tabs, but think that even if we
> revert that change, we'd keep the icons.

Yes, this is orthogonal to making trees first class citizens of perf panel.

[alph, 2017-02-17 00:52:35]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-02-17 00:53:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 02:52:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-17 02:52:22]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[alph, 2017-02-17 16:28:12]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-02-17 16:28:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-17 17:11:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487348892728960, "parent_rev":
"0843f8c3625094b1b3b9b65935bcd1abfd2c9679", "commit_rev":
"8376a0c3554ffb329e74e899f4277f7a80b52448"}

[commit-bot: I haz the power, 2017-02-17 17:12:28]

Description was changed from

==========
DevTools: Add icons to performance pane tabs.

BUG=693238
==========

to

==========
DevTools: Add icons to performance pane tabs.

BUG=693238

Review-Url: https://codereview.chromium.org/2689213012
Cr-Commit-Position: refs/heads/master@{#451321}
Committed:
https://chromium.googlesource.com/chromium/src/+/8376a0c3554ffb329e74e899f427...
==========

[commit-bot: I haz the power, 2017-02-17 17:12:29]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8376a0c3554ffb329e74e899f427...

[alph, 2017-02-24 02:53:15]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2714923002/ by alph@chromium.org.

The reason for reverting is: Per UX folks request.