Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2689213011: [Mac RTL] Draw the drop arrow in the correct location when mirrored. (Closed)

Created:
3 years, 10 months ago by Avi (use Gerrit)
Modified:
3 years, 10 months ago
Reviewers:
erikchen
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac RTL] Draw the drop arrow in the correct location when mirrored. BUG=690120 TEST=drag text over the tab bar; arrow should be in the correct drop location Review-Url: https://codereview.chromium.org/2689213011 Cr-Commit-Position: refs/heads/master@{#451112} Committed: https://chromium.googlesource.com/chromium/src/+/feec29a8aa1c45832bdee9892c29ae55e88ecc94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +11 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
3 years, 10 months ago (2017-02-16 19:55:57 UTC) #6
erikchen
lgtm
3 years, 10 months ago (2017-02-16 20:52:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689213011/1
3 years, 10 months ago (2017-02-16 21:27:49 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-16 22:12:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/feec29a8aa1c45832bdee9892c29...

Powered by Google App Engine
This is Rietveld 408576698