Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2689183003: Convert layout test move-up-down-should-skip-hidden-elements.html to performance test (Closed)

Created:
3 years, 10 months ago by yosin_UTC9
Modified:
3 years, 10 months ago
Reviewers:
tkent, yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert layout test move-up-down-should-skip-hidden-elements.html to performance test This patch converts layout test "move-up-down-should-skip-hidden-elements.html" to performance tests, move line up and move line down, since this layout test measures verifies execution speed regression. Using performance test is easier to track performance regression than detecting timeout in layout test. BUG=691841 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2689183003 Cr-Commit-Position: refs/heads/master@{#450278} Committed: https://chromium.googlesource.com/chromium/src/+/c8a73d769c8090eb22f25cea950303a50ba98788

Patch Set 1 : 2017-02-14T11:22:37 #

Total comments: 1

Patch Set 2 : 2017-02-14T13:13:29 #

Messages

Total messages: 19 (12 generated)
yosin_UTC9
PTAL
3 years, 10 months ago (2017-02-14 02:28:17 UTC) #5
yoichio
https://codereview.chromium.org/2689183003/diff/1/third_party/WebKit/PerformanceTests/Editing/move-down-with-hidden-elements.html File third_party/WebKit/PerformanceTests/Editing/move-down-with-hidden-elements.html (right): https://codereview.chromium.org/2689183003/diff/1/third_party/WebKit/PerformanceTests/Editing/move-down-with-hidden-elements.html#newcode9 third_party/WebKit/PerformanceTests/Editing/move-down-with-hidden-elements.html:9: for (let count = 0; count < 100; ++count) ...
3 years, 10 months ago (2017-02-14 04:00:20 UTC) #8
yosin_UTC9
On 2017/02/14 at 04:00:20, yoichio wrote: > https://codereview.chromium.org/2689183003/diff/1/third_party/WebKit/PerformanceTests/Editing/move-down-with-hidden-elements.html > File third_party/WebKit/PerformanceTests/Editing/move-down-with-hidden-elements.html (right): > > https://codereview.chromium.org/2689183003/diff/1/third_party/WebKit/PerformanceTests/Editing/move-down-with-hidden-elements.html#newcode9 ...
3 years, 10 months ago (2017-02-14 04:10:47 UTC) #9
yosin_UTC9
PTAL Change to traversal 10,000 to get significant difference on number of unrendered elements.
3 years, 10 months ago (2017-02-14 04:15:04 UTC) #12
yoichio
lgtm
3 years, 10 months ago (2017-02-14 04:18:49 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689183003/20001
3 years, 10 months ago (2017-02-14 04:21:10 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 06:19:14 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c8a73d769c8090eb22f25cea9503...

Powered by Google App Engine
This is Rietveld 408576698