Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2689173003: Provide default month for Date.UTC (Closed)

Created:
3 years, 10 months ago by vabr (Chromium)
Modified:
3 years, 10 months ago
Reviewers:
Dan Ehrenberg
CC:
v8-reviews_googlegroups.com, jgruber, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Provide default month for Date.UTC After https://github.com/tc39/ecma262/pull/642, Date.UTC no longer requires the month argument to be specified. The spec provides 0 as its default value. This CL updates the builtins-date.cc code to reflect that and drops the test suppression for test262/built-ins/Date/UTC/return-value. BUG=v8:5534 Review-Url: https://codereview.chromium.org/2689173003 Cr-Commit-Position: refs/heads/master@{#43193} Committed: https://chromium.googlesource.com/v8/v8/+/566e05c11ef98280cff2401422ab244f29112084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M src/builtins/builtins-date.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
vabr (Chromium)
Hi Dan, One more (last!) review request from tonight :). Thanks, Vaclav
3 years, 10 months ago (2017-02-14 00:46:40 UTC) #4
Dan Ehrenberg
lgtm
3 years, 10 months ago (2017-02-14 13:54:05 UTC) #7
Dan Ehrenberg
cc jgruber, yang
3 years, 10 months ago (2017-02-14 13:55:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689173003/1
3 years, 10 months ago (2017-02-14 15:12:22 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 15:14:07 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/566e05c11ef98280cff2401422ab244f291...

Powered by Google App Engine
This is Rietveld 408576698