Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2689083004: Don't unconditionally generate a layout object for SVG <stop> elements. (Closed)

Created:
3 years, 10 months ago by emilio
Modified:
3 years, 10 months ago
Reviewers:
fs
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't unconditionally generate a layout object for SVG <stop> elements. This is (really!) the last overload missed in https://crrev.com/28ec0e0c2425d480693e8d40510b8093cef1f89f BUG=691205 Review-Url: https://codereview.chromium.org/2689083004 Cr-Commit-Position: refs/heads/master@{#449942} Committed: https://chromium.googlesource.com/chromium/src/+/d6df828820be4b0f22b9bed959fb2bd93f84b331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -12 lines) Patch
D third_party/WebKit/LayoutTests/svg/crash-svg-marker-in-html.html View 1 chunk +0 lines, -11 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/svg-in-html.html View 1 chunk +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGStopElement.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
emilio
fs, could you take a look? Thanks! and sorry for missing this one :(
3 years, 10 months ago (2017-02-13 11:47:19 UTC) #2
fs
lgtm
3 years, 10 months ago (2017-02-13 11:48:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2689083004/1
3 years, 10 months ago (2017-02-13 12:06:57 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 13:44:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d6df828820be4b0f22b9bed959fb...

Powered by Google App Engine
This is Rietveld 408576698