Deprecate CSS values zoom:reset and zoom:document.

Deprecate CSS values zoom:reset and zoom:document.

Add a deprecation message and output to the console when zoom:reset or
zoom:document are used in preparation for their removal.

BUG=664668, 642613
Review-Url: https://codereview.chromium.org/2689063002
Cr-Commit-Position: refs/heads/master@{#450871}
Committed: https://chromium.googlesource.com/chromium/src/+/c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1

[Bret, 2017-02-12 00:25:45]

Description was changed from

==========
Deprecate CSS values zoom:reset and zoom:document.

Add a deprecation message and output to the console when zoom:reset or
zoom:document are used in preparation for their removal.

BUG=664668,642613
==========

to

==========
Deprecate CSS values zoom:reset and zoom:document.

Add a deprecation message and output to the console when zoom:reset or
zoom:document are used in preparation for their removal.

BUG=664668,642613
==========

[Bret, 2017-02-12 00:25:45]

bsep@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2017-02-12 23:31:05]

On 2017/02/12 00:26:02, Bret Sepulveda wrote:

Nice to see this moving forwards -- are there any tests for the deprecation
warning? In my experience, normally adding deprecation warnings ends up showing
in the expected.txt of all the layout tests using the feature.

[Bret, 2017-02-14 21:56:32]

On 2017/02/12 23:31:05, Timothy Loh wrote:
> On 2017/02/12 00:26:02, Bret Sepulveda wrote:
> 
> Nice to see this moving forwards -- are there any tests for the deprecation
> warning? In my experience, normally adding deprecation warnings ends up
showing
> in the expected.txt of all the layout tests using the feature.

Good point. I found a few tests that were using the deprecated features, but
they seemed to be using them as a no-op rather than actually testing their
characteristics, so I changed the usages to zoom:normal instead (which is the
intended no-op value).

[Timothy Loh, 2017-02-14 23:47:14]

On 2017/02/14 21:56:32, Bret Sepulveda wrote:
> On 2017/02/12 23:31:05, Timothy Loh wrote:
> > On 2017/02/12 00:26:02, Bret Sepulveda wrote:
> > 
> > Nice to see this moving forwards -- are there any tests for the deprecation
> > warning? In my experience, normally adding deprecation warnings ends up
> showing
> > in the expected.txt of all the layout tests using the feature.
> 
> Good point. I found a few tests that were using the deprecated features, but
> they seemed to be using them as a no-op rather than actually testing their
> characteristics, so I changed the usages to zoom:normal instead (which is the
> intended no-op value).

Sorry if I wasn't clear here, I mean that we should make sure we have a test
that hits this code path.

[Bret, 2017-02-15 01:42:37]

On 2017/02/14 23:47:14, Timothy Loh wrote:
> On 2017/02/14 21:56:32, Bret Sepulveda wrote:
> > On 2017/02/12 23:31:05, Timothy Loh wrote:
> > > On 2017/02/12 00:26:02, Bret Sepulveda wrote:
> > > 
> > > Nice to see this moving forwards -- are there any tests for the
deprecation
> > > warning? In my experience, normally adding deprecation warnings ends up
> > showing
> > > in the expected.txt of all the layout tests using the feature.
> > 
> > Good point. I found a few tests that were using the deprecated features, but
> > they seemed to be using them as a no-op rather than actually testing their
> > characteristics, so I changed the usages to zoom:normal instead (which is
the
> > intended no-op value).
> 
> Sorry if I wasn't clear here, I mean that we should make sure we have a test
> that hits this code path.

Ah okay. The other tests didn't really make sense to add to, so I made a small
new test to hit the deprecation messages. How's this?

[Timothy Loh, 2017-02-15 03:09:18]

lgtm with a few small comments

https://codereview.chromium.org/2689063002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html
(right):

https://codereview.chromium.org/2689063002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html:1:
<body>
<!doctype html> is standard for layout tests unless explicitly testing quirks
mode

https://codereview.chromium.org/2689063002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html:4:
</body>
Better to add this so you don't need an expected.png:

<script>
if (window.testRunner)
  testRunner.dumpAsText();
</script>

https://codereview.chromium.org/2689063002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2689063002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:418: return
willBeRemoved("zoom: \"reset\"", M59, "4997605029314560");
Here and below, quotes should be around everything and not just reset/document,
since the CSS is [zoom: reset] and not [zoom: "reset"].

[Bret, 2017-02-15 20:55:59]

https://codereview.chromium.org/2689063002/diff/40001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html
(right):

https://codereview.chromium.org/2689063002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html:1:
<body>
On 2017/02/15 03:09:18, Timothy Loh wrote:
> <!doctype html> is standard for layout tests unless explicitly testing quirks
> mode

Done.

https://codereview.chromium.org/2689063002/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/css/deprecated-zoom-properties.html:4:
</body>
On 2017/02/15 03:09:18, Timothy Loh wrote:
> Better to add this so you don't need an expected.png:
> 
> <script>
> if (window.testRunner)
>   testRunner.dumpAsText();
> </script>

Done.

https://codereview.chromium.org/2689063002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/frame/Deprecation.cpp (right):

https://codereview.chromium.org/2689063002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/frame/Deprecation.cpp:418: return
willBeRemoved("zoom: \"reset\"", M59, "4997605029314560");
On 2017/02/15 03:09:18, Timothy Loh wrote:
> Here and below, quotes should be around everything and not just
reset/document,
> since the CSS is [zoom: reset] and not [zoom: "reset"].

Done.

[Bret, 2017-02-15 20:56:08]

The CQ bit was checked by bsep@chromium.org

[Bret, 2017-02-15 20:56:08]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2689063002/#ps60001
(title: "final comments")

[commit-bot: I haz the power, 2017-02-15 20:57:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 21:04:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 21:04:50]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Bret, 2017-02-15 22:45:50]

The CQ bit was checked by bsep@chromium.org

[Bret, 2017-02-15 22:45:50]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/2689063002/#ps80001
(title: "merge")

[commit-bot: I haz the power, 2017-02-15 22:46:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 00:50:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 00:50:37]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[Bret, 2017-02-16 02:33:45]

The CQ bit was checked by bsep@chromium.org

[commit-bot: I haz the power, 2017-02-16 02:34:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 04:44:11]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487212425878250,
"parent_rev": "353c830f4a83db572dab3e949fd5bc611f519f84", "commit_rev":
"c96485dba1223b9a7c6378b4a5b6c5a883e2b3e1"}

[commit-bot: I haz the power, 2017-02-16 04:45:17]

Description was changed from

==========
Deprecate CSS values zoom:reset and zoom:document.

Add a deprecation message and output to the console when zoom:reset or
zoom:document are used in preparation for their removal.

BUG=664668,642613
==========

to

==========
Deprecate CSS values zoom:reset and zoom:document.

Add a deprecation message and output to the console when zoom:reset or
zoom:document are used in preparation for their removal.

BUG=664668,642613

Review-Url: https://codereview.chromium.org/2689063002
Cr-Commit-Position: refs/heads/master@{#450871}
Committed:
https://chromium.googlesource.com/chromium/src/+/c96485dba1223b9a7c6378b4a5b6...
==========

[commit-bot: I haz the power, 2017-02-16 04:45:19]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/c96485dba1223b9a7c6378b4a5b6...