[Devtools] Added context menus for removing request blocking in network

[Devtools] Added context menus for removing request blocking in network

This patch adds context menus for removing request blocking entries from
the context menus of network panel.

see: http://imgur.com/a/n1Tbt

R=luoe,pfeldman
BUG=691114
Review-Url: https://codereview.chromium.org/2688983002
Cr-Commit-Position: refs/heads/master@{#450245}
Committed: https://chromium.googlesource.com/chromium/src/+/f435bbbcaa33ff17a3da0704284f0e6ca4130c57

[allada, 2017-02-10 22:43:53]

Description was changed from

==========
[Devtools] Added context menus for removing request blocking in network

This patch adds context menus for removing request blocking entries from
the context menus of network panel.

R=luoe,pfeldman
BUG=691114
==========

to

==========
[Devtools] Added context menus for removing request blocking in network

This patch adds context menus for removing request blocking entries from
the context menus of network panel.

see: http://imgur.com/a/n1Tbt

R=luoe,pfeldman
BUG=691114
==========

[allada, 2017-02-10 22:44:01]

PTL

[pfeldman, 2017-02-11 01:34:59]

https://codereview.chromium.org/2688983002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2688983002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1107: var
blockedSetting = Common.moduleSetting('blockedURLs');
Let's prefix this to be networkBlockedURLs now that we are serious about
releasing it.

https://codereview.chromium.org/2688983002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1117:
const croppedURL =
blockedSettingData[blockedURLIndex].trimMiddle(maxBlockedURLLength);
What if there is no urlWithoutScheme? You fall into this branch.

https://codereview.chromium.org/2688983002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1127:
const croppedDomain =
blockedSettingData[blockedDomainIndex].trimMiddle(maxBlockedURLLength);
ditto

[allada, 2017-02-11 02:29:18]

PTaL

https://codereview.chromium.org/2688983002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2688983002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1107: var
blockedSetting = Common.moduleSetting('blockedURLs');
On 2017/02/11 01:34:59, pfeldman wrote:
> Let's prefix this to be networkBlockedURLs now that we are serious about
> releasing it.

Done.

https://codereview.chromium.org/2688983002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1117:
const croppedURL =
blockedSettingData[blockedURLIndex].trimMiddle(maxBlockedURLLength);
On 2017/02/11 01:34:59, pfeldman wrote:
> What if there is no urlWithoutScheme? You fall into this branch.

Done.

https://codereview.chromium.org/2688983002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1127:
const croppedDomain =
blockedSettingData[blockedDomainIndex].trimMiddle(maxBlockedURLLength);
On 2017/02/11 01:34:59, pfeldman wrote:
> ditto

Done.

[allada, 2017-02-11 03:19:55]

Patchset #2 (id:20001) has been deleted

[allada, 2017-02-11 03:20:01]

Patchset #2 (id:40001) has been deleted

[allada, 2017-02-11 03:20:14]

Patchset #2 (id:60001) has been deleted

[allada, 2017-02-11 03:20:56]

Patchset #2 (id:80001) has been deleted

[luoe, 2017-02-13 06:45:30]

lgtm

https://codereview.chromium.org/2688983002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2688983002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1117:
const croppedURL =
blockedSettingData[blockedURLIndex].trimMiddle(maxBlockedURLLength);
nit: ... = urlWithoutScheme.trimMiddle(...)?

https://codereview.chromium.org/2688983002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1127:
const croppedDomain =
blockedSettingData[blockedDomainIndex].trimMiddle(maxBlockedURLLength);
ditto, ... = domain.trimMiddle(...)?

[allada, 2017-02-13 16:29:25]

https://codereview.chromium.org/2688983002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js
(right):

https://codereview.chromium.org/2688983002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1117:
const croppedURL =
blockedSettingData[blockedURLIndex].trimMiddle(maxBlockedURLLength);
On 2017/02/13 06:45:30, luoe wrote:
> nit: ... = urlWithoutScheme.trimMiddle(...)?

These are not the same. urlWithoutScheme is the resource URL data.
blockedSettingsData[blockedURLIndex] is a pattern of urls to block. We want to
show the pattern since that's what they'd be unlocking.

https://codereview.chromium.org/2688983002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js:1127:
const croppedDomain =
blockedSettingData[blockedDomainIndex].trimMiddle(maxBlockedURLLength);
On 2017/02/13 06:45:30, luoe wrote:
> ditto, ... = domain.trimMiddle(...)?

same as above.

[pfeldman, 2017-02-13 20:15:50]

lgtm

[allada, 2017-02-13 20:27:01]

The CQ bit was checked by allada@chromium.org

[allada, 2017-02-13 20:27:01]

The patchset sent to the CQ was uploaded after l-g-t-m from luoe@chromium.org,
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2688983002/#ps140001
(title: "changes")

[commit-bot: I haz the power, 2017-02-13 20:27:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 22:06:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 22:06:50]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[allada, 2017-02-13 23:27:01]

The CQ bit was checked by allada@chromium.org

[allada, 2017-02-13 23:27:02]

The patchset sent to the CQ was uploaded after l-g-t-m from luoe@chromium.org,
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/2688983002/#ps160001
(title: "fix test")

[commit-bot: I haz the power, 2017-02-13 23:28:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[allada, 2017-02-14 01:12:36]

The CQ bit was unchecked by allada@chromium.org

[allada, 2017-02-14 01:12:41]

The CQ bit was checked by allada@chromium.org

[commit-bot: I haz the power, 2017-02-14 01:13:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 04:28:40]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1487034761245140,
"parent_rev": "968553977ba5cf51409101104a51431d60b051cd", "commit_rev":
"f435bbbcaa33ff17a3da0704284f0e6ca4130c57"}

[commit-bot: I haz the power, 2017-02-14 04:29:42]

Description was changed from

==========
[Devtools] Added context menus for removing request blocking in network

This patch adds context menus for removing request blocking entries from
the context menus of network panel.

see: http://imgur.com/a/n1Tbt

R=luoe,pfeldman
BUG=691114
==========

to

==========
[Devtools] Added context menus for removing request blocking in network

This patch adds context menus for removing request blocking entries from
the context menus of network panel.

see: http://imgur.com/a/n1Tbt

R=luoe,pfeldman
BUG=691114

Review-Url: https://codereview.chromium.org/2688983002
Cr-Commit-Position: refs/heads/master@{#450245}
Committed:
https://chromium.googlesource.com/chromium/src/+/f435bbbcaa33ff17a3da0704284f...
==========

[commit-bot: I haz the power, 2017-02-14 04:29:44]

Committed patchset #5 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/f435bbbcaa33ff17a3da0704284f...