[Web Agents API]: Start fleshing out generated code.

third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc

Index: third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc b/third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
index a5517c8352701a25eef4aad384779bf8b1183a51..201be68c3ec98d3e9703ab3f7e48c9d2433f6fe4 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
+++ b/third_party/WebKit/Source/bindings/tests/results/core/test_interface_3.cc
@@ -10,17 +10,23 @@
 
 // clang-format off
 
-#include "test_interface_3.h"
+#include "web/api/test_interface_3.h"
 
-// TODO(dglazkov): Implement generating includes.
-#include "wtf/text/WTFString.h.h"
+// TODO(dglazkov): Properly sort the includes.
+#include "wtf/text/WTFString.h"
+#include "bindings/tests/idls/core/TestInterface3.h"
 
-namespace blink {
-namespace api {
+namespace web {
 
-// TODO(dglazkov): Implement constant generation
+TestInterface3* TestInterface3::Create(blink::TestInterface3* test_interface_3) {

[haraken, 2017/02/11 09:56:46]

Can test_interface_3 be null? It looks a bit strange that a Create method can
return nullptr.

[dglazkov, 2017/02/11 21:56:21]

Yeah, that's the main reason I ended up using factories instead of just plain
constructors. The objects these wrappers wrap often could be 0 and seemed more
convenient to accommodate this in the factory, rather than do null-checking
inline. For example, in https://codereview.chromium.org/2591803002:

Element* Element::GetFirstElementChild() const {
  return Element::Create(blink::ParentNode::firstElementChild(*element()));
}

the firstElementChild could be nullptr, but I don't need to do anything special
when generating this code. Instead, the factory makes sure to return a nullptr
instead of a wrapper that holds a nullptr.

+  return test_interface_3 ? new TestInterface3(test_interface_3) : nullptr;
+}
+
+DEFINE_TRACE(TestInterface3) {
+  visitor->trace(test_interface_3_);
+}
 
-// TODO(dglazkov): Implement constructor generation
+// TODO(dglazkov): Implement constant generation
 
 // TODO(dglazkov): Implement attribute getter/setter generation
 // DOMString readonlyStringifierAttribute
@@ -28,5 +34,11 @@ namespace api {
 // TODO(dglazkov): Implement method generation
 // void TestInterface3::voidMethodDocument
 
-}  // namespace api
-}  // namespace blink
+TestInterface3::TestInterface3(blink::TestInterface3* test_interface_3)
+    : test_interface_3_(test_interface_3) {}
+
+blink::TestInterface3* TestInterface3::test_interface_3() const {
+  return test_interface_3_;
+}
+
+}  // namespace web