Chromium Code Reviews| Index: third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl |
| diff --git a/third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl b/third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl |
| index 068070842c10f66c3bab7887976e2ff087cb29ff..f3c56ad2c17e4be29f305c2be7f8f831c07c5503 100644 |
| --- a/third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl |
| +++ b/third_party/WebKit/Source/bindings/templates/web_module_interface.h.tmpl |
| @@ -2,24 +2,45 @@ |
| {% include 'copyright_block.txt' %} |
| -// TODO(dglazkov): Use chromium-style path. |
| -#ifndef {{class_name.macro_case}}_H |
| -#define {{class_name.macro_case}}_H |
| +#ifndef WEB_API_{{class_name.macro_case}}_H |
| +#define WEB_API_{{class_name.macro_case}}_H |
| {% for include_file in header_includes %} |
| #include "{{include_file}}" |
| {% endfor %} |
| namespace blink { |
| -namespace api { |
| +class {{class_name.upper_camel_case}}; |
| +} |
| -class {{class_name.upper_camel_case}}{{inherits_expression}} { |
| +namespace web { |
| +class {{class_name.upper_camel_case}} : public {% if not base_class -%} |
| + blink::GarbageCollectedFinalized<{{class_name.upper_camel_case}}> |
|
haraken
2017/02/11 09:56:46
I'm not sure if this needs to be 'Finalized'. If t
dglazkov
2017/02/11 21:56:20
Oh! Thanks for the tip. Changed.
|
| +{%- else -%} |
| + {{base_class}} |
| +{%- endif %} { |
| + public: |
| + virtual ~{{class_name.upper_camel_case}}() = default; |
| + |
| + static {{class_name.upper_camel_case}}* Create(blink::{{class_name.upper_camel_case}}*); |
| + |
| +{% if not base_class %} |
| + DECLARE_STATIC(); |
|
haraken
2017/02/11 09:56:46
What is this for?
dglazkov
2017/02/11 21:56:21
That's... a booger :D
I meant to type DECLARE_TRA
|
| +{% endif %} |
| + |
| + protected: |
| + explicit {{class_name.upper_camel_case}}(blink::{{class_name.upper_camel_case}}* {{class_name.snake_case}}); |
| + blink::{{class_name.upper_camel_case}}* {{class_name.snake_case}}() const; |
| + |
| +{% if not base_class %} |
| + private: |
| + blink::Member<blink::{{class_name.upper_camel_case}}> {{class_name.snake_case}}_; |
| +{% endif %} |
| }; |
| -} // namespace api |
| -} // namespace blink |
| +} // namespace web |
| -#endif // {{class_name.macro_case}}_H |
| +#endif // WEB_API_{{class_name.macro_case}}_H |
| {% endfilter %} |