Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 2688923002: DevTools: update widths of console toolbar elements (Closed)

Created:
3 years, 10 months ago by luoe
Modified:
3 years, 10 months ago
Reviewers:
lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: update widths of console toolbar elements Adjusts the style so that console's toolbar elements so that the filter input never shrinks to 0, but preserving the ability to see the settings gear icon. BUG=690695 Review-Url: https://codereview.chromium.org/2688923002 Cr-Commit-Position: refs/heads/master@{#449814} Committed: https://chromium.googlesource.com/chromium/src/+/20bc73c9bcd8f5da0ef7e5772d367a309b7f80bd

Patch Set 1 #

Patch Set 2 : min-width with shrink #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/toolbar.css View 1 3 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
luoe
ptal
3 years, 10 months ago (2017-02-10 19:15:31 UTC) #3
lushnikov
lgtm
3 years, 10 months ago (2017-02-10 19:16:32 UTC) #4
pfeldman
wait, how is this Ok? filter is the only input field, it should be shrinking ...
3 years, 10 months ago (2017-02-10 19:19:55 UTC) #8
lushnikov
it does shrink to a min width - it has a "width" set in a ...
3 years, 10 months ago (2017-02-10 19:32:43 UTC) #9
luoe
Before the patch, the settings gear icon starts getting cut when the viewport is at ...
3 years, 10 months ago (2017-02-10 20:30:26 UTC) #10
pfeldman
lgtm
3 years, 10 months ago (2017-02-10 21:59:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688923002/20001
3 years, 10 months ago (2017-02-10 23:29:59 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 01:14:50 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/20bc73c9bcd8f5da0ef7e5772d36...

Powered by Google App Engine
This is Rietveld 408576698