Migrate WTF::HashSet::add() to ::insert() [continued]

third_party/WebKit/Source/wtf/HashSet.h

Index: third_party/WebKit/Source/wtf/HashSet.h
diff --git a/third_party/WebKit/Source/wtf/HashSet.h b/third_party/WebKit/Source/wtf/HashSet.h
index e50fcb2b167d086727dc69d1f0f28ff438e6830e..58da800a35ca2c071d6ca27d7a08eb388b84fce7 100644
--- a/third_party/WebKit/Source/wtf/HashSet.h
+++ b/third_party/WebKit/Source/wtf/HashSet.h
@@ -108,8 +108,9 @@ class HashSet {
   // and a bool that is true if an new entry was added.
   template <typename IncomingValueType>
   AddResult insert(IncomingValueType&&);
-  template <typename IncomingValueType>
-  AddResult add(IncomingValueType&&);
+  // TODO(pilgrim) remove this
+  // template <typename IncomingValueType>
+  // AddResult add(IncomingValueType&&);
 
   // An alternate version of add() that finds the object by hashing and
   // comparing with some other type, to avoid the cost of type conversion if
@@ -261,12 +262,12 @@ inline typename HashSet<T, U, V, W>::AddResult HashSet<T, U, V, W>::insert(
 
 // TODO(pilgrim) remove this method once all references and subclasses
 // have been migrated to insert() method
-template <typename T, typename U, typename V, typename W>
-template <typename IncomingValueType>
-inline typename HashSet<T, U, V, W>::AddResult HashSet<T, U, V, W>::add(
-    IncomingValueType&& value) {
-  return m_impl.add(std::forward<IncomingValueType>(value));
-}
+// template <typename T, typename U, typename V, typename W>
+// template <typename IncomingValueType>
+// inline typename HashSet<T, U, V, W>::AddResult HashSet<T, U, V, W>::add(
+//    IncomingValueType&& value) {
+//  return m_impl.add(std::forward<IncomingValueType>(value));
+//}

[haraken, 2017/02/11 09:33:43]

Can we remove this?

 
 template <typename Value,
           typename HashFunctions,