Revert [MacViews] Implemented text context menu

Revert [MacViews] Implemented text context menu

This change reverts the implementation of TextField context menus.

The original feature was targetting MacViews, however this breaks menus on non
Mac platforms.

Textfield::OnCaretBoundsChanged deletes the MenuModel while the MenuController
is still active. Subsequent UI events attempt to access the now destroyed model.

This is causing two major crashes on dev channel. So I am reverting to unblock.

TBR=sky@chromium.org, nasko@chromium.org

Revert "[MacViews] Implemented text context menu"

This reverts commit 375ddabe9cdc45673e112c5b1b06cc754aa45759.
Original review: https://codereview.chromium.org/2164483006

BUG=617436, 690097, 690443
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2688883002
Cr-Commit-Position: refs/heads/master@{#449645}
Committed: https://chromium.googlesource.com/chromium/src/+/6dcf90cf6c047e222f9da8d2567b60d66fa2fe87

[jonross, 2017-02-10 16:02:11]

Description was changed from

==========
Revert [MacViews] Implemented text context menu

This change reverts the implementation of TextField context menus.

The original feature was targetting MacViews, however this breaks menus on non
Mac platforms.

Textfield::OnCaretBoundsChanged deletes the MenuModel while the MenuController
is still active. Subsequent UI events attempt to access the now destroyed model.

This is causing two major crashes on dev channel. So I am reverting to unblock.

Revert "[MacViews] Implemented text context menu"

This reverts commit 375ddabe9cdc45673e112c5b1b06cc754aa45759.
Original review: https://codereview.chromium.org/2164483006

BUG=617436, 690097, 690443
==========

to

==========
Revert [MacViews] Implemented text context menu

This change reverts the implementation of TextField context menus.

The original feature was targetting MacViews, however this breaks menus on non
Mac platforms.

Textfield::OnCaretBoundsChanged deletes the MenuModel while the MenuController
is still active. Subsequent UI events attempt to access the now destroyed model.

This is causing two major crashes on dev channel. So I am reverting to unblock.

Revert "[MacViews] Implemented text context menu"

This reverts commit 375ddabe9cdc45673e112c5b1b06cc754aa45759.
Original review: https://codereview.chromium.org/2164483006

BUG=617436, 690097, 690443
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jonross, 2017-02-10 16:02:41]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-02-10 16:03:48]

jonross@chromium.org changed reviewers:
+ nasko@chromium.org

[jonross, 2017-02-10 16:03:49]

nasko@chromium.org: Please review changes in

[jonross, 2017-02-10 16:04:19]

Description was changed from

==========
Revert [MacViews] Implemented text context menu

This change reverts the implementation of TextField context menus.

The original feature was targetting MacViews, however this breaks menus on non
Mac platforms.

Textfield::OnCaretBoundsChanged deletes the MenuModel while the MenuController
is still active. Subsequent UI events attempt to access the now destroyed model.

This is causing two major crashes on dev channel. So I am reverting to unblock.

Revert "[MacViews] Implemented text context menu"

This reverts commit 375ddabe9cdc45673e112c5b1b06cc754aa45759.
Original review: https://codereview.chromium.org/2164483006

BUG=617436, 690097, 690443
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert [MacViews] Implemented text context menu

This change reverts the implementation of TextField context menus.

The original feature was targetting MacViews, however this breaks menus on non
Mac platforms.

Textfield::OnCaretBoundsChanged deletes the MenuModel while the MenuController
is still active. Subsequent UI events attempt to access the now destroyed model.

This is causing two major crashes on dev channel. So I am reverting to unblock.

TBR=sky@chromium.org, nasko@chromium.org

Revert "[MacViews] Implemented text context menu"

This reverts commit 375ddabe9cdc45673e112c5b1b06cc754aa45759.
Original review: https://codereview.chromium.org/2164483006

BUG=617436, 690097, 690443
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[jonross, 2017-02-10 16:04:27]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-02-10 16:04:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 17:15:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486742667516190, "parent_rev":
"bba2078bfd6da7ee4df5cd3b3974ff37a39d46e6", "commit_rev":
"6dcf90cf6c047e222f9da8d2567b60d66fa2fe87"}

[commit-bot: I haz the power, 2017-02-10 17:16:22]

Description was changed from

==========
Revert [MacViews] Implemented text context menu

This change reverts the implementation of TextField context menus.

The original feature was targetting MacViews, however this breaks menus on non
Mac platforms.

Textfield::OnCaretBoundsChanged deletes the MenuModel while the MenuController
is still active. Subsequent UI events attempt to access the now destroyed model.

This is causing two major crashes on dev channel. So I am reverting to unblock.

TBR=sky@chromium.org, nasko@chromium.org

Revert "[MacViews] Implemented text context menu"

This reverts commit 375ddabe9cdc45673e112c5b1b06cc754aa45759.
Original review: https://codereview.chromium.org/2164483006

BUG=617436, 690097, 690443
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Revert [MacViews] Implemented text context menu

This change reverts the implementation of TextField context menus.

The original feature was targetting MacViews, however this breaks menus on non
Mac platforms.

Textfield::OnCaretBoundsChanged deletes the MenuModel while the MenuController
is still active. Subsequent UI events attempt to access the now destroyed model.

This is causing two major crashes on dev channel. So I am reverting to unblock.

TBR=sky@chromium.org, nasko@chromium.org

Revert "[MacViews] Implemented text context menu"

This reverts commit 375ddabe9cdc45673e112c5b1b06cc754aa45759.
Original review: https://codereview.chromium.org/2164483006

BUG=617436, 690097, 690443
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2688883002
Cr-Commit-Position: refs/heads/master@{#449645}
Committed:
https://chromium.googlesource.com/chromium/src/+/6dcf90cf6c047e222f9da8d2567b...
==========

[commit-bot: I haz the power, 2017-02-10 17:16:26]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6dcf90cf6c047e222f9da8d2567b...