Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 2688813003: Mus Demo: Add square size parameter to the WindowTreeData constructor (Closed)

Created:
1 year, 7 months ago by fwang
Modified:
1 year, 7 months ago
Reviewers:
rjkroege
CC:
chromium-reviews, rjkroege, tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus Demo: Add square size parameter to the WindowTreeData constructor For a demonstration of multiple external windows it is interesting to have different content drawn in order to distinguish the windows. This is also useful to distinguish internal VS external mode. This CL adds a parameter to the WindowTreeData constructor that can be used to specify the square size in pixels. BUG=666958 R=rjkroege@chromium.org Review-Url: https://codereview.chromium.org/2688813003 Cr-Commit-Position: refs/heads/master@{#450030} Committed: https://chromium.googlesource.com/chromium/src/+/c50f6629b59e6e3e3087ca8dd3fb73518c4bf0dd

Patch Set 1 #

Patch Set 2 : Rebasing #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -8 lines) Patch
M services/ui/demo/mus_demo.cc View 1 2 5 chunks +15 lines, -8 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (14 generated)
fwang
PTAL
1 year, 7 months ago (2017-02-10 15:06:11 UTC) #1
rjkroege
lgtm
1 year, 7 months ago (2017-02-10 19:58:56 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688813003/40001
1 year, 7 months ago (2017-02-13 18:36:50 UTC) #15
commit-bot: I haz the power
1 year, 7 months ago (2017-02-13 18:49:06 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c50f6629b59e6e3e3087ca8dd3fb...

Powered by Google App Engine
This is Rietveld 408576698