Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 2688753002: Add acquire/release to global variable. (Closed)

Created:
3 years, 10 months ago by bcwhite
Modified:
3 years, 10 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add acquire/release to global variable. Acquire/Release is needed to ensure that other threads cannot access member variables without them being committed to memory. BUG=620813 Review-Url: https://codereview.chromium.org/2688753002 Cr-Commit-Position: refs/heads/master@{#449630} Committed: https://chromium.googlesource.com/chromium/src/+/d3bbe536eab7b3fd2f22568dfb1650bf78732ba3

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M base/debug/activity_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/activity_tracker.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
bcwhite
3 years, 10 months ago (2017-02-09 20:12:34 UTC) #3
manzagop (departed)
lgtm
3 years, 10 months ago (2017-02-10 16:13:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688753002/20001
3 years, 10 months ago (2017-02-10 16:24:21 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 16:29:48 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d3bbe536eab7b3fd2f22568dfb16...

Powered by Google App Engine
This is Rietveld 408576698