cc: Distinguish single texture mask from normal masks

cc: Distinguish single texture mask from normal masks

Tiling a mask with filters is very difficult and rare case. As a result,
we would like to disable mask tiling in these situations, this CL adds a
flag in PictureLayerImpl to show whether the mask layer has only a
single texture.

BUG=567293
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2688673003
Cr-Commit-Position: refs/heads/master@{#449718}
Committed: https://chromium.googlesource.com/chromium/src/+/936c16d92cb3caf815cd31fa455576aac2bece75

[sunxd, 2017-02-09 16:42:34]

Description was changed from

==========
cc: Add is_single_texture_mask boolean to PictureLayerImpl.

Tiling a mask with filters is very difficult and rare case. As a result,
we would like to disable mask tiling in these situations, this CL adds a
flag in PictureLayerImpl to show whether the mask layer has only a
single texture.

BUG=567293
==========

to

==========
cc: Add is_single_texture_mask boolean to PictureLayerImpl.

Tiling a mask with filters is very difficult and rare case. As a result,
we would like to disable mask tiling in these situations, this CL adds a
flag in PictureLayerImpl to show whether the mask layer has only a
single texture.

BUG=567293
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[sunxd, 2017-02-09 16:45:50]

The CQ bit was checked by sunxd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 16:46:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunxd, 2017-02-09 16:47:11]

sunxd@chromium.org changed reviewers:
+ enne@chromium.org, trchen@chromium.org

[sunxd, 2017-02-09 16:47:11]

I broke the big mask tiling CL into several small parts, hoping to simplify both
the reviewing and maintaining.

[commit-bot: I haz the power, 2017-02-09 18:14:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 18:14:39]

Dry run: This issue passed the CQ dry run.

[enne (OOO), 2017-02-09 18:37:06]

https://codereview.chromium.org/2688673003/diff/1/cc/layers/layer.h
File cc/layers/layer.h (right):

https://codereview.chromium.org/2688673003/diff/1/cc/layers/layer.h#newcode315
cc/layers/layer.h:315: virtual void SetIsMask(bool is_mask) {}
Sorry for the API nit, but because these two functions are related and some
combinations don't make sense, like IsSingleTextureMask(true) and IsMask(false),
but can you make this SetMaskType with an enum of NO_MASK, SINGLE_TEXTURE_MASK,
... MASK? (not sure what to call the normal type).

[sunxd, 2017-02-10 16:20:24]

Description was changed from

==========
cc: Add is_single_texture_mask boolean to PictureLayerImpl.

Tiling a mask with filters is very difficult and rare case. As a result,
we would like to disable mask tiling in these situations, this CL adds a
flag in PictureLayerImpl to show whether the mask layer has only a
single texture.

BUG=567293
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Distinguish single texture mask from normal masks

Tiling a mask with filters is very difficult and rare case. As a result,
we would like to disable mask tiling in these situations, this CL adds a
flag in PictureLayerImpl to show whether the mask layer has only a
single texture.

BUG=567293
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[sunxd, 2017-02-10 16:20:32]

PTAL.

[enne (OOO), 2017-02-10 17:04:20]

Thanks, lgtm!

[sunxd, 2017-02-10 17:09:48]

The CQ bit was checked by sunxd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 17:10:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 17:45:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 17:45:07]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sunxd, 2017-02-10 18:04:07]

The CQ bit was checked by sunxd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 18:05:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 20:01:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 20:01:19]

Dry run: This issue passed the CQ dry run.

[sunxd, 2017-02-10 20:14:22]

The CQ bit was checked by sunxd@chromium.org

[sunxd, 2017-02-10 20:14:22]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2688673003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2017-02-10 20:15:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 20:20:34]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486757662632030,
"parent_rev": "bc2345c988d08f7b711cefc73fd42223b116211e", "commit_rev":
"936c16d92cb3caf815cd31fa455576aac2bece75"}

[commit-bot: I haz the power, 2017-02-10 20:21:05]

Description was changed from

==========
cc: Distinguish single texture mask from normal masks

Tiling a mask with filters is very difficult and rare case. As a result,
we would like to disable mask tiling in these situations, this CL adds a
flag in PictureLayerImpl to show whether the mask layer has only a
single texture.

BUG=567293
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Distinguish single texture mask from normal masks

Tiling a mask with filters is very difficult and rare case. As a result,
we would like to disable mask tiling in these situations, this CL adds a
flag in PictureLayerImpl to show whether the mask layer has only a
single texture.

BUG=567293
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2688673003
Cr-Commit-Position: refs/heads/master@{#449718}
Committed:
https://chromium.googlesource.com/chromium/src/+/936c16d92cb3caf815cd31fa4555...
==========

[commit-bot: I haz the power, 2017-02-10 20:21:06]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/936c16d92cb3caf815cd31fa4555...