Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1638)

Issue 2688663003: MD Settings: Fix CrSettingsPeoplePageSyncPageTest.SyncPage test when Vulcanized. (Closed)

Created:
1 year, 3 months ago by dpapad
Modified:
1 year, 3 months ago
Reviewers:
tommycli
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Fix CrSettingsPeoplePageSyncPageTest.SyncPage test when Vulcanized. BUG=673825 Review-Url: https://codereview.chromium.org/2688663003 Cr-Commit-Position: refs/heads/master@{#449446} Committed: https://chromium.googlesource.com/chromium/src/+/fa60e4a929a37c89098b96656ba29e45e8eda0ec

Patch Set 1 #

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/test/data/webui/settings/people_page_sync_page_test.js View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
dpapad
1 year, 3 months ago (2017-02-09 20:36:49 UTC) #2
tommycli
lgtm
1 year, 3 months ago (2017-02-09 21:17:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688663003/20001
1 year, 3 months ago (2017-02-09 21:31:08 UTC) #5
commit-bot: I haz the power
1 year, 3 months ago (2017-02-09 22:48:59 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/fa60e4a929a37c89098b96656ba2...

Powered by Google App Engine
This is Rietveld 408576698