Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issue 2688623006: Add initial list of captive portal certificates (Closed)

Created:
3 years, 10 months ago by meacer
Modified:
3 years, 10 months ago
Reviewers:
estark
CC:
chromium-reviews, arv+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add initial list of captive portal certificates This list contains the SPKI hashes of top captive portal certificates. All certs should only cause name mismatch errors. BUG=640835 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2688623006 Cr-Commit-Position: refs/heads/master@{#450523} Committed: https://chromium.googlesource.com/chromium/src/+/4cb673a8d363c7ddb6f05a009a313e7e10d21b11

Patch Set 1 #

Patch Set 2 : Sort #

Total comments: 1

Patch Set 3 : Add link to documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+124 lines, -6 lines) Patch
M chrome/browser/resources/ssl/ssl_error_assistant/ssl_error_assistant.asciipb View 1 2 1 chunk +124 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
meacer
estark: PTAL?
3 years, 10 months ago (2017-02-10 02:12:12 UTC) #3
estark
https://codereview.chromium.org/2688623006/diff/20001/chrome/browser/resources/ssl/ssl_error_assistant/ssl_error_assistant.asciipb File chrome/browser/resources/ssl/ssl_error_assistant/ssl_error_assistant.asciipb (right): https://codereview.chromium.org/2688623006/diff/20001/chrome/browser/resources/ssl/ssl_error_assistant/ssl_error_assistant.asciipb#newcode18 chrome/browser/resources/ssl/ssl_error_assistant/ssl_error_assistant.asciipb:18: # The rest of the certificates are case-insensitive sorted ...
3 years, 10 months ago (2017-02-11 17:46:33 UTC) #4
meacer
Added a go link pointing to the instructions.
3 years, 10 months ago (2017-02-14 01:06:57 UTC) #5
estark
lgtm, thanks!
3 years, 10 months ago (2017-02-14 21:59:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688623006/40001
3 years, 10 months ago (2017-02-14 22:08:25 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 00:23:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/4cb673a8d363c7ddb6f05a009a31...

Powered by Google App Engine
This is Rietveld 408576698