Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2688603003: [Mac] Fix for zoom decoration regression (Closed)

Created:
3 years, 10 months ago by spqchan
Modified:
3 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fix for zoom decoration regression The decoration should update if its visibility has changed BUG=687903 Review-Url: https://codereview.chromium.org/2688603003 Cr-Commit-Position: refs/heads/master@{#449700} Committed: https://chromium.googlesource.com/chromium/src/+/d88656394d232e54292d28ba07659182b3e331c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/ui/cocoa/location_bar/zoom_decoration.mm View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
spqchan
PTAL
3 years, 10 months ago (2017-02-10 17:56:37 UTC) #6
Avi (use Gerrit)
lgtm
3 years, 10 months ago (2017-02-10 19:03:06 UTC) #7
spqchan
On 2017/02/10 19:03:06, Avi wrote: > lgtm thanks!
3 years, 10 months ago (2017-02-10 19:11:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688603003/1
3 years, 10 months ago (2017-02-10 19:12:00 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 19:47:29 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d88656394d232e54292d28ba0765...

Powered by Google App Engine
This is Rietveld 408576698