Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2688563002: split human reason (Closed)

Created:
3 years, 10 months ago by nodir
Modified:
3 years, 10 months ago
Reviewers:
iannucci, martiniss
CC:
chromium-reviews, infra-reviews+recipes-py_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

split human reason A failure human reason may have newline chars. Use Stream.write_split instead of Stream.write_line. R=iannucci@chromium.org, martiniss@chromium.org BUG=690090 Review-Url: https://codereview.chromium.org/2688563002 Committed: https://github.com/luci/recipes-py/commit/699e274630d839a4d49ac48744ad71216b9553c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M recipes.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
nodir
PTAL
3 years, 10 months ago (2017-02-08 19:28:58 UTC) #1
iannucci
lgtm
3 years, 10 months ago (2017-02-08 19:30:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688563002/1
3 years, 10 months ago (2017-02-08 19:30:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/recipes-py/commit/699e274630d839a4d49ac48744ad71216b9553c6
3 years, 10 months ago (2017-02-08 19:33:42 UTC) #7
Vadim Sh.
3 years, 10 months ago (2017-02-08 20:06:52 UTC) #8
Message was sent while issue was closed.
Morbid :)

Powered by Google App Engine
This is Rietveld 408576698