Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1267)

Issue 2688523002: Revert of Use timer task queue for RenderMediaLog (Closed)

Created:
3 years, 10 months ago by altimin
Modified:
3 years, 10 months ago
CC:
chfremer+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use timer task queue for RenderMediaLog (patchset #2 id:20001 of https://codereview.chromium.org/2647453003/ ) Reason for revert: VideoFullscreenOrientationLockTests became flaky (see crbug.com/676070) Original issue's description: > Use timer task queue for RenderMediaLog > > As a part of effort to post tasks to correct scheduler task queues instead > of default one, use frame-specific timer task runner for RenderMediaLog tasks. > > BUG=676805 > > Review-Url: https://codereview.chromium.org/2647453003 > Cr-Commit-Position: refs/heads/master@{#448777} > Committed: https://chromium.googlesource.com/chromium/src/+/c4d24a8a8d97013513f2f668734ce608a82a541a TBR=jochen@chromium.org,dalecurtis@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=676805 Review-Url: https://codereview.chromium.org/2688523002 Cr-Commit-Position: refs/heads/master@{#449023} Committed: https://chromium.googlesource.com/chromium/src/+/9ea4b653af65fdb18c37f54d9986708f5277f8db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M content/renderer/media/render_media_log.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/render_media_log.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/media/render_media_log_unittest.cc View 2 chunks +1 line, -3 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
altimin
Created Revert of Use timer task queue for RenderMediaLog
3 years, 10 months ago (2017-02-08 17:27:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688523002/1
3 years, 10 months ago (2017-02-08 17:27:45 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 17:29:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9ea4b653af65fdb18c37f54d9986...

Powered by Google App Engine
This is Rietveld 408576698