Update ChangeBuilder to the new driver

Update ChangeBuilder to the new driver

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/a191011c03ae1931c33814674a678e379bcf2ad3

[Brian Wilkerson, 2017-02-08 20:53:47]

brianwilkerson@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-02-08 21:09:11]

LGTM

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart
(right):

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart:23:
* complete until all of the futures returned by [addFileEdit] have completed.
Maybe this getter should return a Future that completes when all addFileEdit()
invocations are complete. So, there would be no way for the clients to make a
mistake. I guess most of them will wait for addFileEdit() anyway, but maybe not.

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart:35:
String path, int timeStamp, void buildFileEdit(FileEditBuilder builder));
BTW, I think that ideally we should migrate from timestamps to content MD5s.

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/test/sr...
File pkg/analysis_server/test/src/utilities/change_builder_core_test.dart
(right):

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/test/sr...
pkg/analysis_server/test/src/utilities/change_builder_core_test.dart:26:
TestSource source = new TestSource('/test.dart');
It seems that using TestSource is not required anymore.
Just String path can be used instead of source.fullName.

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/test/sr...
File pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart
(right):

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/test/sr...
pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart:33: await
driver.getResult(path);
You don't use this result, maybe you don't need to request it.
It will be requested again/anyway in builder.createFileEditBuilder().

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/test/sr...
pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart:119:
ClassDeclaration classA = unit.declarations[0];
Here you do use, the result, but there is a cheaper way.
You could ask for driver.getUnitElement(path).getType('A').type instead.

As a bonus, we will get rid of
resolutionMap.elementDeclaredByClassDeclaration(...) :-)

[Brian Wilkerson, 2017-02-09 03:22:42]

PTAL

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart
(right):

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart:23:
* complete until all of the futures returned by [addFileEdit] have completed.
I considered that, and I'm still not completely convinced either way. If we
returned a Future here we could presumably *not* return a Future from
addFileEdit. At least, I don't think there's a reason to have both.

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart:35:
String path, int timeStamp, void buildFileEdit(FileEditBuilder builder));
> BTW, I think that ideally we should migrate from timestamps to content MD5s.

I'm not sure we want to require clients to compute MD5 hashes of files. In any
case, not in this CL.

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/test/sr...
File pkg/analysis_server/test/src/utilities/change_builder_core_test.dart
(right):

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/test/sr...
pkg/analysis_server/test/src/utilities/change_builder_core_test.dart:26:
TestSource source = new TestSource('/test.dart');
Done

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/test/sr...
File pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart
(right):

https://codereview.chromium.org/2688513003/diff/1/pkg/analysis_server/test/sr...
pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart:33: await
driver.getResult(path);
Removed

[scheglov, 2017-02-09 03:25:58]

LGTM

[Brian Wilkerson, 2017-02-09 15:51:46]

Description was changed from

==========
Update ChangeBuilder to the new driver
==========

to

==========
Update ChangeBuilder to the new driver

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/a191011c03ae1931c33814674a678e379bcf2ad3
==========

[Brian Wilkerson, 2017-02-09 15:51:47]

Committed patchset #2 (id:20001) manually as
a191011c03ae1931c33814674a678e379bcf2ad3 (presubmit successful).