Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart

Issue 2688513003: Update ChangeBuilder to the new driver (Closed)
Patch Set: addressed comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_dart.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart
diff --git a/pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart b/pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart
index 8c357433bbe276abfcfbf2365ce05ff20dc521da..8fbcbdf48989e1921b96f3ba6565d65c06e69e68 100644
--- a/pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart
+++ b/pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart
@@ -2,11 +2,10 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-library analysis_server.plugin.edit.utilities.change_builder_core;
+import 'dart:async';
import 'package:analysis_server/plugin/protocol/protocol.dart';
import 'package:analysis_server/src/utilities/change_builder_core.dart';
-import 'package:analyzer/src/generated/source.dart';
/**
* A builder used to build a [SourceChange].
@@ -20,18 +19,20 @@ abstract class ChangeBuilder {
factory ChangeBuilder() = ChangeBuilderImpl;
/**
- * Return the source change that was built.
+ * Return the source change that was built. The source change will not be
+ * complete until all of the futures returned by [addFileEdit] have completed.
*/
SourceChange get sourceChange;
/**
* Use the [buildFileEdit] function to create a collection of edits to the
- * given [source]. The edits will be added to the source change that is being
- * built. The [timeStamp] is the time at which the [source] was last modified
- * and is used by clients to ensure that it is safe to apply the edits.
+ * file with the given [path]. The edits will be added to the source change
+ * that is being built. The [timeStamp] is the time at which the file was last
+ * modified and is used by clients to ensure that it is safe to apply the
+ * edits.
*/
- void addFileEdit(Source source, int timeStamp,
- void buildFileEdit(FileEditBuilder builder));
+ Future<Null> addFileEdit(
+ String path, int timeStamp, void buildFileEdit(FileEditBuilder builder));
}
/**
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698