Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2688503003: Add FadeOut delay animation to MouseLeave (Closed)

Created:
3 years, 10 months ago by chaopeng
Modified:
3 years, 10 months ago
Reviewers:
bokan, weiliangc
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add FadeOut delay animation to MouseLeave MouseLeave should cause a scrollbar fade. This patch we add a |PostDelayedAnimationTask| call at the bottom of |ScrollbarAnimationController::DidMouseLeave|. BUG=689166 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2688503003 Cr-Commit-Position: refs/heads/master@{#449994} Committed: https://chromium.googlesource.com/chromium/src/+/71bfc364fbfcfd07810b71eaf1374e8a13e447bb

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M cc/input/scrollbar_animation_controller.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M cc/input/scrollbar_animation_controller_thinning_unittest.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
chaopeng
PTAL. Thank you.
3 years, 10 months ago (2017-02-08 19:13:45 UTC) #3
bokan
lgtm https://codereview.chromium.org/2688503003/diff/20001/cc/input/scrollbar_animation_controller_thinning_unittest.cc File cc/input/scrollbar_animation_controller_thinning_unittest.cc (right): https://codereview.chromium.org/2688503003/diff/20001/cc/input/scrollbar_animation_controller_thinning_unittest.cc#newcode949 cc/input/scrollbar_animation_controller_thinning_unittest.cc:949: // Ensure we have a delay fadeout animation ...
3 years, 10 months ago (2017-02-10 15:50:58 UTC) #8
chaopeng
weiliangc@chromium.org: PTAL. Thank you.
3 years, 10 months ago (2017-02-10 16:03:49 UTC) #10
weiliangc
lgtm
3 years, 10 months ago (2017-02-13 16:13:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688503003/40001
3 years, 10 months ago (2017-02-13 16:23:20 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 17:41:17 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/71bfc364fbfcfd07810b71eaf137...

Powered by Google App Engine
This is Rietveld 408576698