Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2688483002:
ClientRedirect reload should use FrameLoadTypeReloadMainResource (Closed)
|
Created:
3 years, 10 months ago by Takashi Toyoshima Modified:
3 years, 10 months ago CC:
chromium-reviews, blink-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionClientRedirect reload should use FrameLoadTypeReloadMainResource
If fasterLocationReload feature is enabled, all reload with
ClientRedirect should switch to use FrameLoadTypeReloadMainResource
instead of FrameLoadTypeReload.
BUG=689683
Review-Url: https://codereview.chromium.org/2688483002
Cr-Commit-Position: refs/heads/master@{#449179}
Committed: https://chromium.googlesource.com/chromium/src/+/c5b26425b504565a5f8c9b3771ff547ac18c29fd
Patch Set 1 #
Messages
Total messages: 21 (12 generated)
Description was changed from ========== ClientRedirect reload should use FrameLoadTypeReloadMainResource If fasterLocationReload feature is enabled, all reload with ClientRedirect should switch to use FrameLoadTypeReloadMainResource instead of FrameLoadTypeReload. BUG=689683 ========== to ========== ClientRedirect reload should use FrameLoadTypeReloadMainResource If fasterLocationReload feature is enabled, all reload with ClientRedirect should switch to use FrameLoadTypeReloadMainResource instead of FrameLoadTypeReload. BUG=689683 ==========
toyoshim@chromium.org changed reviewers: + kinuko@chromium.org
The CQ bit was checked by toyoshim@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
ptal
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
toyoshim@chromium.org changed reviewers: + haraken@chromium.org
+haraken for modules approval
On 2017/02/09 00:39:40, Takashi Toyoshima wrote: > +haraken for modules approval LGTM
btw, any plan to deprecate this non-standard module? this looks useless today, and would just provide footprint.
The CQ bit was checked by toyoshim@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486603216820680, "parent_rev":
"56b23f3064d47916ee13dadbbb7e87e2d15b80fd", "commit_rev":
"c5b26425b504565a5f8c9b3771ff547ac18c29fd"}
Message was sent while issue was closed.
Description was changed from ========== ClientRedirect reload should use FrameLoadTypeReloadMainResource If fasterLocationReload feature is enabled, all reload with ClientRedirect should switch to use FrameLoadTypeReloadMainResource instead of FrameLoadTypeReload. BUG=689683 ========== to ========== ClientRedirect reload should use FrameLoadTypeReloadMainResource If fasterLocationReload feature is enabled, all reload with ClientRedirect should switch to use FrameLoadTypeReloadMainResource instead of FrameLoadTypeReload. BUG=689683 Review-Url: https://codereview.chromium.org/2688483002 Cr-Commit-Position: refs/heads/master@{#449179} Committed: https://chromium.googlesource.com/chromium/src/+/c5b26425b504565a5f8c9b3771ff... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c5b26425b504565a5f8c9b3771ff... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
