[chrome.cast.channel] Remove event logging.

[chrome.cast.channel] Remove event logging.

Cast Channel event logs have not been collected since launch of Media Router.
This removes all code collecting detailed logs, but leaves support for collecting net:: and Cast authentication errors for reporting via onError.

This also removes chrome.cast.channel.setAuthorityKeys() and its tests, which is a no-op and is no longer used.

BUG=513801, 601171
Review-Url: https://codereview.chromium.org/2688463003
Cr-Commit-Position: refs/heads/master@{#450191}
Committed: https://chromium.googlesource.com/chromium/src/+/ed9773f95712d0477ef7f3f2e7be3d6d79d934b1

[mark a. foltz, 2017-02-08 23:18:58]

The CQ bit was checked by mfoltz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 23:19:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mark a. foltz, 2017-02-08 23:25:17]

Description was changed from

==========
[chrome.cast.channel] Remove event logging.

Cast Channel event logs have not been collected since launch of Media Router.
This removes all code collecting detailed logs, but leaves support for
collecting
net:: and Cast authentication errors for reporting via onError.

BUG=513801
==========

to

==========
[chrome.cast.channel] Remove event logging.

Cast Channel event logs have not been collected since launch of Media Router.
This removes all code collecting detailed logs, but leaves support for
collecting
net:: and Cast authentication errors for reporting via onError.

BUG=513801,601171
==========

[commit-bot: I haz the power, 2017-02-09 00:31:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 00:31:04]

Dry run: This issue passed the CQ dry run.

[mark a. foltz, 2017-02-09 01:12:55]

mfoltz@chromium.org changed reviewers:
+ benwells@chromium.org, kmarshall@chromium.org

[mark a. foltz, 2017-02-09 01:12:56]

PTAL (+erickung as an FYI)

[mark a. foltz, 2017-02-09 01:13:00]

The CQ bit was checked by mfoltz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 01:13:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mark a. foltz, 2017-02-09 01:30:27]

On 2017/02/09 at 01:12:56, mark a. foltz wrote:
> PTAL (+erickung as an FYI)

benwells@ for extensions/common/api/cast_channel.idl, although feel free to look
further if you desire :-)

[commit-bot: I haz the power, 2017-02-09 02:16:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 02:16:19]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[benwells, 2017-02-09 04:42:00]

idl lgtm

[Kevin M, 2017-02-09 19:28:54]

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
File extensions/browser/api/cast_channel/cast_channel_apitest.cc (left):

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
extensions/browser/api/cast_channel/cast_channel_apitest.cc:471: 
Add line item in the CL description for this change

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
File extensions/browser/api/cast_channel/cast_transport.cc (right):

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
extensions/browser/api/cast_channel/cast_transport.cc:259: if
(IsTerminalWriteState(write_state_) && write_state_ == WRITE_STATE_ERROR) {
Checking IsTerminalWriteState() is unnecessary here, as the only state that
matters here is WRITE_STATE_ERROR.

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
File extensions/browser/api/cast_channel/logger.cc (right):

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
extensions/browser/api/cast_channel/logger.cc:151:
MaybeSetLastErrors(socket_event, &last_errors_[channel_id]);
Since this only makes changes for errors now, can we inspect the call sites and
remove all non-error logging for this class? Those calls are just pure overhead
now

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
File extensions/browser/api/cast_channel/logger.h (right):

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
extensions/browser/api/cast_channel/logger.h:28: struct LastErrors {
low pri nit: LastErrors seems like a misnomer; this refers to a discrete event
so it would be better described as a singular Error. Maybe ErrorDetails?

https://codereview.chromium.org/2688463003/diff/20001/extensions/common/api/c...
File extensions/common/api/cast_channel.idl (left):

https://codereview.chromium.org/2688463003/diff/20001/extensions/common/api/c...
extensions/common/api/cast_channel.idl:178: // Callback from
<code>setAuthorityKeys</code> method.
Document the removal of this function in CL desc

[mark a. foltz, 2017-02-10 21:04:39]

Description was changed from

==========
[chrome.cast.channel] Remove event logging.

Cast Channel event logs have not been collected since launch of Media Router.
This removes all code collecting detailed logs, but leaves support for
collecting
net:: and Cast authentication errors for reporting via onError.

BUG=513801,601171
==========

to

==========
[chrome.cast.channel] Remove event logging.

Cast Channel event logs have not been collected since launch of Media Router.
This removes all code collecting detailed logs, but leaves support for
collecting net:: and Cast authentication errors for reporting via onError.

This also removes chrome.cast.channel.setAuthorityKeys() and its tests, which is
a no-op and is no longer used.

BUG=513801,601171
==========

[mark a. foltz, 2017-02-10 21:55:16]

PTAL

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
File extensions/browser/api/cast_channel/cast_channel_apitest.cc (left):

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
extensions/browser/api/cast_channel/cast_channel_apitest.cc:471: 
On 2017/02/09 at 19:28:54, Kevin M wrote:
> Add line item in the CL description for this change

Done.

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
File extensions/browser/api/cast_channel/cast_transport.cc (right):

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
extensions/browser/api/cast_channel/cast_transport.cc:259: if
(IsTerminalWriteState(write_state_) && write_state_ == WRITE_STATE_ERROR) {
On 2017/02/09 at 19:28:54, Kevin M wrote:
> Checking IsTerminalWriteState() is unnecessary here, as the only state that
matters here is WRITE_STATE_ERROR.

Done.

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
File extensions/browser/api/cast_channel/logger.cc (right):

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
extensions/browser/api/cast_channel/logger.cc:151:
MaybeSetLastErrors(socket_event, &last_errors_[channel_id]);
On 2017/02/09 at 19:28:54, Kevin M wrote:
> Since this only makes changes for errors now, can we inspect the call sites
and remove all non-error logging for this class? Those calls are just pure
overhead now

Done, in places which didn't complicate the calling code with extra error
checks.

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
File extensions/browser/api/cast_channel/logger.h (right):

https://codereview.chromium.org/2688463003/diff/20001/extensions/browser/api/...
extensions/browser/api/cast_channel/logger.h:28: struct LastErrors {
On 2017/02/09 at 19:28:54, Kevin M wrote:
> low pri nit: LastErrors seems like a misnomer; this refers to a discrete event
so it would be better described as a singular Error. Maybe ErrorDetails?

It's designed to collect the last net:: error and the last authentication error,
so it's possible to report multiple errors through one object.

https://codereview.chromium.org/2688463003/diff/20001/extensions/common/api/c...
File extensions/common/api/cast_channel.idl (left):

https://codereview.chromium.org/2688463003/diff/20001/extensions/common/api/c...
extensions/common/api/cast_channel.idl:178: // Callback from
<code>setAuthorityKeys</code> method.
On 2017/02/09 at 19:28:54, Kevin M wrote:
> Document the removal of this function in CL desc

Done.

[Kevin M, 2017-02-13 21:55:56]

lgtm

https://codereview.chromium.org/2688463003/diff/40001/extensions/browser/api/...
File extensions/browser/api/cast_channel/cast_transport.h (right):

https://codereview.chromium.org/2688463003/diff/40001/extensions/browser/api/...
extensions/browser/api/cast_channel/cast_transport.h:23: class IPEndPoint;
nit: Remove this

https://codereview.chromium.org/2688463003/diff/40001/extensions/browser/api/...
extensions/browser/api/cast_channel/cast_transport.h:33: class Logger;
Remove this

[mark a. foltz, 2017-02-13 22:22:02]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2017-02-13 22:22:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, kmarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/2688463003/#ps60001
(title: "Fix fwd declarations & rebase.")

[commit-bot: I haz the power, 2017-02-13 22:22:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 22:43:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 22:43:06]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[mark a. foltz, 2017-02-13 23:13:59]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2017-02-13 23:14:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
benwells@chromium.org, kmarshall@chromium.org
Link to the patchset: https://codereview.chromium.org/2688463003/#ps80001
(title: "Fix missing #include")

[commit-bot: I haz the power, 2017-02-13 23:14:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 01:36:47]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487027639907860,
"parent_rev": "f3d8d29fe53a0eafff9088e447451c99a4a92ecf", "commit_rev":
"ed9773f95712d0477ef7f3f2e7be3d6d79d934b1"}

[commit-bot: I haz the power, 2017-02-14 01:37:38]

Description was changed from

==========
[chrome.cast.channel] Remove event logging.

Cast Channel event logs have not been collected since launch of Media Router.
This removes all code collecting detailed logs, but leaves support for
collecting net:: and Cast authentication errors for reporting via onError.

This also removes chrome.cast.channel.setAuthorityKeys() and its tests, which is
a no-op and is no longer used.

BUG=513801,601171
==========

to

==========
[chrome.cast.channel] Remove event logging.

Cast Channel event logs have not been collected since launch of Media Router.
This removes all code collecting detailed logs, but leaves support for
collecting net:: and Cast authentication errors for reporting via onError.

This also removes chrome.cast.channel.setAuthorityKeys() and its tests, which is
a no-op and is no longer used.

BUG=513801,601171

Review-Url: https://codereview.chromium.org/2688463003
Cr-Commit-Position: refs/heads/master@{#450191}
Committed:
https://chromium.googlesource.com/chromium/src/+/ed9773f95712d0477ef7f3f2e7be...
==========

[commit-bot: I haz the power, 2017-02-14 01:37:40]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ed9773f95712d0477ef7f3f2e7be...