Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 2688413009: Remove dead ExpressionUnexpectedToken from parser-base.h (Closed)

Created:
3 years, 10 months ago by vabr (Chromium)
Modified:
3 years, 10 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove dead ExpressionUnexpectedToken from parser-base.h The method ExpressionUnexpectedToken is not referenced anywhere apart from its definition. This CL removes it. The association with the bug below is only through discovering the dead code when working on a fix for that bug. BUG=v8:5692 Review-Url: https://codereview.chromium.org/2688413009 Cr-Commit-Position: refs/heads/master@{#43203} Committed: https://chromium.googlesource.com/v8/v8/+/8a54a471758d0c732ac30b9d4026717b7c60020c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M src/parsing/parser-base.h View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
vabr (Chromium)
Hi Adam, While I work on the ESCAPED_STRICT_RESERVED_WORD CL (thanks for your help there), would ...
3 years, 10 months ago (2017-02-15 00:45:23 UTC) #4
adamk
lgtm
3 years, 10 months ago (2017-02-15 00:55:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688413009/1
3 years, 10 months ago (2017-02-15 01:01:32 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 01:03:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8a54a471758d0c732ac30b9d4026717b7c6...

Powered by Google App Engine
This is Rietveld 408576698