Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2079)

Unified Diff: ui/display/screen_android.cc

Issue 2688413007: Add display::GetDisplayNearestView (Closed)
Patch Set: fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/display/screen.cc ('k') | ui/display/screen_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/display/screen_android.cc
diff --git a/ui/display/screen_android.cc b/ui/display/screen_android.cc
new file mode 100644
index 0000000000000000000000000000000000000000..3ada8ba92c096e09226935cf67fd43ee3446e57d
--- /dev/null
+++ b/ui/display/screen_android.cc
@@ -0,0 +1,20 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ui/display/screen.h"
+
+#include "base/logging.h"
+
+namespace display {
+
+// static
+gfx::NativeWindow Screen::WindowForView(gfx::NativeView view) {
+ // Android cannot use implement this method here to convert |NativeView|
+ // to |NativeWindow| since it causes cyclic dependency.
+ // |GetDisplayNearestView| should be overriden directly.
+ NOTREACHED() << "Inherited class should override |GetDisplayNearestView|.";
oshima 2017/03/14 11:53:24 It's not clear what went wrong with this log messa
Jinsuk Kim 2017/03/14 23:23:26 Correct. Android code here is just to make the bui
+ return nullptr;
+}
+
+} // namespace display
« no previous file with comments | « ui/display/screen.cc ('k') | ui/display/screen_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698