Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Side by Side Diff: ui/display/screen_android.cc

Issue 2688413007: Add display::GetDisplayNearestView (Closed)
Patch Set: fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/display/screen.cc ('k') | ui/display/screen_aura.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "ui/display/screen.h"
6
7 #include "base/logging.h"
8
9 namespace display {
10
11 // static
12 gfx::NativeWindow Screen::WindowForView(gfx::NativeView view) {
13 // Android cannot use implement this method here to convert |NativeView|
14 // to |NativeWindow| since it causes cyclic dependency.
15 // |GetDisplayNearestView| should be overriden directly.
16 NOTREACHED() << "Inherited class should override |GetDisplayNearestView|.";
oshima 2017/03/14 11:53:24 It's not clear what went wrong with this log messa
Jinsuk Kim 2017/03/14 23:23:26 Correct. Android code here is just to make the bui
17 return nullptr;
18 }
19
20 } // namespace display
OLDNEW
« no previous file with comments | « ui/display/screen.cc ('k') | ui/display/screen_aura.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698