Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart

Issue 2688413003: Extract BackendUsage, MirrorsData, and CheckedModeHelpers from Backend. (Closed)
Patch Set: Cleanup Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
index 48b333c00e310ebd50876189f7233c1df91ec78f..9fbbad3f75dcebd513164e942302f369f4c26784 100644
--- a/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
+++ b/pkg/compiler/lib/src/js_emitter/program_builder/collector.dart
@@ -68,7 +68,9 @@ class Collector {
* that needs to be emitted.
*/
Function computeClassFilter() {
- if (backend.isTreeShakingDisabled) return (ClassElement cls) => true;
+ if (backend.mirrorsData.isTreeShakingDisabled) {
+ return (ClassElement cls) => true;
+ }
Set<ClassElement> unneededClasses = new Set<ClassElement>();
// The [Bool] class is not marked as abstract, but has a factory
@@ -112,37 +114,39 @@ class Collector {
void computeNeededConstants() {
// Make sure we retain all metadata of all elements. This could add new
// constants to the handler.
- if (backend.mustRetainMetadata) {
+ if (backend.mirrorsData.mustRetainMetadata) {
// TODO(floitsch): verify that we don't run through the same elements
// multiple times.
for (Element element in backend.generatedCode.keys) {
- if (backend.isAccessibleByReflection(element)) {
- bool shouldRetainMetadata = backend.retainMetadataOf(element);
+ if (backend.mirrorsData.isAccessibleByReflection(element)) {
+ bool shouldRetainMetadata =
+ backend.mirrorsData.retainMetadataOf(element);
if (shouldRetainMetadata &&
(element.isFunction ||
element.isConstructor ||
element.isSetter)) {
FunctionElement function = element;
function.functionSignature
- .forEachParameter(backend.retainMetadataOf);
+ .forEachParameter(backend.mirrorsData.retainMetadataOf);
}
}
}
for (ClassElement cls in neededClasses) {
final onlyForRti = classesOnlyNeededForRti.contains(cls);
if (!onlyForRti) {
- backend.retainMetadataOf(cls);
+ backend.mirrorsData.retainMetadataOf(cls);
new FieldVisitor(compiler, namer, closedWorld).visitFields(cls, false,
(Element member, js.Name name, js.Name accessorName,
bool needsGetter, bool needsSetter, bool needsCheckedSetter) {
bool needsAccessor = needsGetter || needsSetter;
- if (needsAccessor && backend.isAccessibleByReflection(member)) {
- backend.retainMetadataOf(member);
+ if (needsAccessor &&
+ backend.mirrorsData.isAccessibleByReflection(member)) {
+ backend.mirrorsData.retainMetadataOf(member);
}
});
}
}
- typedefsNeededForReflection.forEach(backend.retainMetadataOf);
+ typedefsNeededForReflection.forEach(backend.mirrorsData.retainMetadataOf);
}
JavaScriptConstantCompiler handler = backend.constants;
@@ -172,7 +176,7 @@ class Collector {
// Compute needed typedefs.
typedefsNeededForReflection = Elements.sortedByPosition(closedWorld
.allTypedefs
- .where(backend.isAccessibleByReflection)
+ .where(backend.mirrorsData.isAccessibleByReflection)
.toList());
// Compute needed classes.
@@ -301,7 +305,7 @@ class Collector {
} else {
// We also need to emit static const fields if they are available for
// reflection.
- return backend.isAccessibleByReflection(field);
+ return backend.mirrorsData.isAccessibleByReflection(field);
}
});

Powered by Google App Engine
This is Rietveld 408576698