Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2688383006: [Media, Video] Update WMPI when the pipeline gets a new average keyframe distance. (Closed)

Created:
3 years, 10 months ago by whywhat
Modified:
3 years, 10 months ago
Reviewers:
watk
CC:
apacible+watch_chromium.org, chromium-reviews, erickung+watch_chromium.org, feature-media-reviews_chromium.org, miu+watch_chromium.org, posciak+watch_chromium.org, xjz+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media, Video] Update WMPI when the pipeline gets a new average keyframe distance. BUG=688618 TEST=manually followed the repro steps from the bug Review-Url: https://codereview.chromium.org/2688383006 Cr-Commit-Position: refs/heads/master@{#450186} Committed: https://chromium.googlesource.com/chromium/src/+/eecec52c10dffeebd35d273a8999388f98089b80

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M media/base/mock_filters.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/pipeline.h View 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/pipeline_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/pipeline_impl.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M media/filters/pipeline_controller_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/test/pipeline_integration_test_base.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
whywhat
PTaL
3 years, 10 months ago (2017-02-13 22:29:10 UTC) #2
watk
Did you consider having the distance average outlive decoder_stream? It's slightly inconsistent that we keep ...
3 years, 10 months ago (2017-02-13 22:54:33 UTC) #5
whywhat
On 2017/02/13 at 22:54:33, watk wrote: > Did you consider having the distance average outlive ...
3 years, 10 months ago (2017-02-14 01:17:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688383006/1
3 years, 10 months ago (2017-02-14 01:18:20 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 01:26:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eecec52c10dffeebd35d273a8999...

Powered by Google App Engine
This is Rietveld 408576698