Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1898)

Unified Diff: Source/modules/webaudio/AudioBufferSourceNode.h

Issue 26883005: Get rid of custom bindings for AudioBufferSourceNode.buffer setter (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Improve exception message Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/webaudio/AudioBufferSourceNode.h
diff --git a/Source/modules/webaudio/AudioBufferSourceNode.h b/Source/modules/webaudio/AudioBufferSourceNode.h
index 60bc1be80ef36f8d97cacb64b7d5defac904afe6..77cea02d66913dbc673575b267e17c65a218189f 100644
--- a/Source/modules/webaudio/AudioBufferSourceNode.h
+++ b/Source/modules/webaudio/AudioBufferSourceNode.h
@@ -52,9 +52,8 @@ public:
virtual void process(size_t framesToProcess);
virtual void reset();
- // setBuffer() is called on the main thread. This is the buffer we use for playback.
- // returns true on success.
- bool setBuffer(AudioBuffer*);
+ // setBuffer() is called on the main thread. This is the buffer we use for playback.
+ void setBuffer(AudioBuffer*, ExceptionState&);
AudioBuffer* buffer() { return m_buffer.get(); }
// numberOfChannels() returns the number of output channels. This value equals the number of channels from the buffer.
« no previous file with comments | « Source/bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp ('k') | Source/modules/webaudio/AudioBufferSourceNode.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698