|
|
Description[cleanup] Remove unnecessary Scope::RareData::operator new
Inheriting from ZoneObject already provides this operator.
R=marja@chromium.org
Review-Url: https://codereview.chromium.org/2688283002
Cr-Commit-Position: refs/heads/master@{#43173}
Committed: https://chromium.googlesource.com/v8/v8/+/60f6106f1e16558b30095874be347410f8c023e1
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
The CQ bit was checked by adamk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2017/02/11 00:04:33, adamk wrote: Thanks for these fixups, I was definitely too jumpy when I pushed the button. The two I've seen look great to me.
lgtm - thanks!
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20903) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20910) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
The CQ bit was checked by adamk@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1487027606508110, "parent_rev": "92f0a618a7e148ead6e650a378999c29663e5592", "commit_rev": "60f6106f1e16558b30095874be347410f8c023e1"}
Message was sent while issue was closed.
Description was changed from ========== [cleanup] Remove unnecessary Scope::RareData::operator new Inheriting from ZoneObject already provides this operator. R=marja@chromium.org ========== to ========== [cleanup] Remove unnecessary Scope::RareData::operator new Inheriting from ZoneObject already provides this operator. R=marja@chromium.org Review-Url: https://codereview.chromium.org/2688283002 Cr-Commit-Position: refs/heads/master@{#43173} Committed: https://chromium.googlesource.com/v8/v8/+/60f6106f1e16558b30095874be347410f8c... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/60f6106f1e16558b30095874be347410f8c... |