Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2688283002: [cleanup] Remove unnecessary Scope::RareData::operator new (Closed)

Created:
3 years, 10 months ago by adamk
Modified:
3 years, 10 months ago
Reviewers:
marja
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Remove unnecessary Scope::RareData::operator new Inheriting from ZoneObject already provides this operator. R=marja@chromium.org Review-Url: https://codereview.chromium.org/2688283002 Cr-Commit-Position: refs/heads/master@{#43173} Committed: https://chromium.googlesource.com/v8/v8/+/60f6106f1e16558b30095874be347410f8c023e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/ast/scopes.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
adamk
3 years, 10 months ago (2017-02-11 00:04:33 UTC) #1
caitp
On 2017/02/11 00:04:33, adamk wrote: Thanks for these fixups, I was definitely too jumpy when ...
3 years, 10 months ago (2017-02-11 01:47:05 UTC) #6
marja
lgtm - thanks!
3 years, 10 months ago (2017-02-13 08:01:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688283002/1
3 years, 10 months ago (2017-02-13 16:24:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20903) v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 10 months ago (2017-02-13 16:28:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688283002/1
3 years, 10 months ago (2017-02-13 18:01:34 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/20910) v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED, ...
3 years, 10 months ago (2017-02-13 18:04:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688283002/1
3 years, 10 months ago (2017-02-13 23:13:30 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 23:39:28 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/60f6106f1e16558b30095874be347410f8c...

Powered by Google App Engine
This is Rietveld 408576698