Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 2688233002: Add null checks to the parameters of glGet* calls. (Closed)

Created:
3 years, 10 months ago by Geoff Lang
Modified:
3 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add null checks to the parameters of glGet* calls. The passthrough command buffer wasn't validating that the params values of glGet calls were large enough to hold the resulting data and was potentially passing null pointers to the driver. BUG=602737 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2688233002 Cr-Commit-Position: refs/heads/master@{#449865} Committed: https://chromium.googlesource.com/chromium/src/+/b6ed682b7d37b8f07bf9688b7a61352cd8969661

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc View 6 chunks +18 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Geoff Lang
PTAL
3 years, 10 months ago (2017-02-10 20:41:20 UTC) #6
Geoff Lang
PTAL
3 years, 10 months ago (2017-02-10 20:41:22 UTC) #7
Zhenyao Mo
On 2017/02/10 20:41:22, Geoff Lang wrote: > PTAL lgtm
3 years, 10 months ago (2017-02-10 20:47:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688233002/1
3 years, 10 months ago (2017-02-11 17:02:09 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 17:05:58 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b6ed682b7d37b8f07bf9688b7a61...

Powered by Google App Engine
This is Rietveld 408576698