Issue 268823002: Re-land: Rename experimental.accessibility to accessibilityPrivate

Issue 268823002: Re-land: Rename experimental.accessibility to accessibilityPrivate (Closed)

Created:
6 years, 7 months ago by dmazzoni

Modified:
6 years, 7 months ago

Reviewers:
Nico, David Tseng, not at google - send to devlin

CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, arv+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Re-land: Rename experimental.accessibility to accessibilityPrivate The only difference from the original change is a fix to manifest_guest.json to prevent ChromeVox from breaking in guest mode. (I also added a new test to cover that scenario and prevent future regressions.) Original code review: https://codereview.chromium.org/106973003 BUG=278540, 362442 TBR=thakis Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269243

Patch Set 1 #

Patch Set 2 : Take .gitmodules out of change #

Patch Set 3 : Rebase #

Total comments: 1

Patch Set 4 : Rebase #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -400 lines)			Patch
M	chrome/browser/accessibility/accessibility_extension_api.h	View		1 chunk	+15 lines, -18 lines	0 comments	Download
M	chrome/browser/accessibility/accessibility_extension_api.cc	View		13 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/accessibility/accessibility_extension_apitest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/accessibility/accessibility_manager.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc	View	1 2 3	1 chunk	+36 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/chromeos/chromevox/manifest_guest.json	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/api/_api_features.json	View	1 2 3	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/api/_permission_features.json	View	1 2 3	1 chunk	+5 lines, -0 lines	0 comments	Download
A +	chrome/common/extensions/api/accessibility_private.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/extensions/api/api.gyp	View	1 2 3	2 chunks	+1 line, -1 line	0 comments	Download
D	chrome/common/extensions/api/experimental_accessibility.json	View		1 chunk	+0 lines, -337 lines	0 comments	Download
M	chrome/common/extensions/permissions/chrome_api_permissions.cc	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/common/extensions/permissions/permission_set_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions_api_resources.grd	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/accessibility/get_alerts_for_tab/background.js	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/accessibility/get_alerts_for_tab/manifest.json	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/permissions/enabled/background.js	View		1 chunk	+0 lines, -14 lines	0 comments	Download
M	chrome/test/data/extensions/api_test/permissions/enabled/manifest.json	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/test/data/extensions/api_test/permissions/experimental_disabled/background.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	extensions/common/extension_api.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	extensions/common/permissions/api_permission.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

not at google - send to devlin

lgtm, but where is the test? https://codereview.chromium.org/268823002/diff/10022/chrome/browser/resources/chromeos/chromevox/manifest_guest.json File chrome/browser/resources/chromeos/chromevox/manifest_guest.json (right): https://codereview.chromium.org/268823002/diff/10022/chrome/browser/resources/chromeos/chromevox/manifest_guest.json#newcode15 chrome/browser/resources/chromeos/chromevox/manifest_guest.json:15: "automation", note that ...

6 years, 7 months ago (2014-05-02 23:06:27 UTC) #2

dmazzoni

Sorry, the test is a separate change which I intend to land first: https://codereview.chromium.org/261013009/ On ...

6 years, 7 months ago (2014-05-02 23:09:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/268823002/10022

6 years, 7 months ago (2014-05-07 16:56:59 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-07 18:11:17 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/268823002/50001

6 years, 7 months ago (2014-05-09 06:50:33 UTC) #9

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-09 10:28:08 UTC) #10

Message was sent while issue was closed.

Change committed as 269243

Expand Messages | Collapse Messages