Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 106973003: Rename experimental.accessibility to accessibilityPrivate (Closed)

Created:
7 years ago by dmazzoni
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, yoshiki+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Rename experimental.accessibility to accessibilityPrivate We can land this after cl/57741007 is landed and rolled into Chrome first. BUG=278540 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261291

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Register API in extension_api.cc #

Patch Set 5 : Rebase, fix broken test #

Patch Set 6 : Rebase #

Patch Set 7 : Fix failing tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -393 lines) Patch
M chrome/browser/accessibility/accessibility_extension_api.h View 1 2 3 4 5 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/browser/accessibility/accessibility_extension_api.cc View 1 2 3 4 5 13 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/accessibility/accessibility_extension_apitest.cc View 1 2 3 4 5 6 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/accessibility/accessibility_manager.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/_api_features.json View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
A + chrome/common/extensions/api/accessibility_private.json View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 2 3 4 5 2 chunks +1 line, -1 line 0 comments Download
D chrome/common/extensions/api/experimental_accessibility.json View 1 chunk +0 lines, -337 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/accessibility/get_alerts_for_tab/background.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/accessibility/get_alerts_for_tab/manifest.json View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/permissions/enabled/background.js View 1 2 3 4 5 6 1 chunk +0 lines, -14 lines 1 comment Download
M chrome/test/data/extensions/api_test/permissions/enabled/manifest.json View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/permissions/experimental_disabled/background.js View 1 chunk +3 lines, -3 lines 0 comments Download
M extensions/common/extension_api.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/common/permissions/api_permission.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
dmazzoni
7 years ago (2013-12-11 22:44:05 UTC) #1
not at google - send to devlin
lgtm
7 years ago (2013-12-11 22:59:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/106973003/40001
6 years, 11 months ago (2014-01-02 23:02:39 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) chromedriver2_unittests, nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=209311
6 years, 11 months ago (2014-01-02 23:35:33 UTC) #4
dmazzoni
+thakis for chrome/common/extensions_api_resources.grd Ready to land, I hope... Ben, I'm sorry this got set aside ...
6 years, 8 months ago (2014-04-01 04:25:43 UTC) #5
not at google - send to devlin
https://codereview.chromium.org/106973003/diff/490001/chrome/test/data/extensions/api_test/permissions/enabled/background.js File chrome/test/data/extensions/api_test/permissions/enabled/background.js (left): https://codereview.chromium.org/106973003/diff/490001/chrome/test/data/extensions/api_test/permissions/enabled/background.js#oldcode11 chrome/test/data/extensions/api_test/permissions/enabled/background.js:11: function experimental() { This is fine. You could try ...
6 years, 8 months ago (2014-04-01 14:31:57 UTC) #6
Nico
grd lgtm
6 years, 8 months ago (2014-04-02 01:54:42 UTC) #7
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 8 months ago (2014-04-02 05:51:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/106973003/490001
6 years, 8 months ago (2014-04-02 05:52:04 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 16:59:10 UTC) #10
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=60385
6 years, 8 months ago (2014-04-02 16:59:10 UTC) #11
dmazzoni
The CQ bit was checked by dmazzoni@chromium.org
6 years, 8 months ago (2014-04-02 23:05:55 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/106973003/490001
6 years, 8 months ago (2014-04-02 23:07:50 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 07:05:59 UTC) #14
Message was sent while issue was closed. 
Change committed as 261291

Powered by Google App Engine
This is Rietveld 408576698