Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2688153003: DevTools: fix blackboxing buttons (Closed)

Created:
3 years, 10 months ago by lushnikov
Modified:
3 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: fix blackboxing buttons This patch converts icons in ListWidget to toolbar, which solves a lot of styling issues and adds support to dark theme. BUG=686638 R=pfeldman Review-Url: https://codereview.chromium.org/2688153003 Cr-Commit-Position: refs/heads/master@{#449835} Committed: https://chromium.googlesource.com/chromium/src/+/0770a61ad8dc130e4adecae097fe73c9b6827789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -40 lines) Patch
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ListWidget.js View 1 chunk +11 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/listWidget.css View 1 chunk +1 line, -25 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
lushnikov
please, take
3 years, 10 months ago (2017-02-10 23:38:05 UTC) #1
lushnikov
please, take a look*
3 years, 10 months ago (2017-02-10 23:38:14 UTC) #2
pfeldman
lgtm
3 years, 10 months ago (2017-02-11 01:29:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688153003/1
3 years, 10 months ago (2017-02-11 02:16:51 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 02:24:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0770a61ad8dc130e4adecae097fe...

Powered by Google App Engine
This is Rietveld 408576698