Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2688133002:
[fuzzer] Create a README for libfuzzer fuzzers. (Closed)
Description[fuzzer] Create a README for libfuzzer fuzzers.
NOTRY=true
R=hablich@chromium.org
Review-Url: https://codereview.chromium.org/2688133002
Cr-Commit-Position: refs/heads/master@{#43092}
Committed: https://chromium.googlesource.com/v8/v8/+/fd8ef3b63077141ff7e98301ea44f03085e57b03
Patch Set 1 #
Total comments: 7
Messages
Total messages: 12 (4 generated)
hablich@chromium.org changed reviewers: + machenbach@chromium.org
On 2017/02/10 at 12:06:07, ahaas wrote: > rubberstamp lgtm
The CQ bit was checked by ahaas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1486728707495370, "parent_rev":
"9346cd9b4c50466aa8d50e98c56b84ba47c2a115", "commit_rev":
"fd8ef3b63077141ff7e98301ea44f03085e57b03"}
Message was sent while issue was closed.
Description was changed from ========== [fuzzer] Create a README for libfuzzer fuzzers. NOTRY=true R=hablich@chromium.org ========== to ========== [fuzzer] Create a README for libfuzzer fuzzers. NOTRY=true R=hablich@chromium.org Review-Url: https://codereview.chromium.org/2688133002 Cr-Commit-Position: refs/heads/master@{#43092} Committed: https://chromium.googlesource.com/v8/v8/+/fd8ef3b63077141ff7e98301ea44f03085e... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/v8/v8/+/fd8ef3b63077141ff7e98301ea44f03085e...
Message was sent while issue was closed.
lgtm, thanks a lot for the doc, much appreciated! https://codereview.chromium.org/2688133002/diff/1/test/fuzzer/README.md File test/fuzzer/README.md (right): https://codereview.chromium.org/2688133002/diff/1/test/fuzzer/README.md#newcode3 test/fuzzer/README.md:3: This document describes how to make a new libfuzzer fuzzer for V8. A general introduction to libfuzzer can be found at [here](https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/README.md). In short, libFuzzer is an in-process coverage-driven evolutionary fuzzer. libFuzzer serves you with a sequence of byte arrays that you can use to test your code. libFuzzer tries to generate this sequence of byte arrays in a way that maximizes test coverage. nit: s/found at [here]/found [here] https://codereview.chromium.org/2688133002/diff/1/test/fuzzer/README.md#newco... test/fuzzer/README.md:17: 4) Now you can already compile the fuzzer with `ninja -j 1000 -C out/tmp/v8_simple_foo_fuzzer` nit: Maybe also add a gn call to populate out/tmp or use one of our canonical directlries, like x64.release? https://codereview.chromium.org/2688133002/diff/1/test/fuzzer/README.md#newco... test/fuzzer/README.md:20: * This build rule is needed to compile with gyp Regarding gyp deprecation: How about we abandon fuzzers in gyp? Nuke them from the gyp files and nuke the from the docu?
Message was sent while issue was closed.
https://codereview.chromium.org/2688133002/diff/1/test/fuzzer/README.md File test/fuzzer/README.md (right): https://codereview.chromium.org/2688133002/diff/1/test/fuzzer/README.md#newcode3 test/fuzzer/README.md:3: This document describes how to make a new libfuzzer fuzzer for V8. A general introduction to libfuzzer can be found at [here](https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/README.md). In short, libFuzzer is an in-process coverage-driven evolutionary fuzzer. libFuzzer serves you with a sequence of byte arrays that you can use to test your code. libFuzzer tries to generate this sequence of byte arrays in a way that maximizes test coverage. On 2017/02/10 at 15:46:03, Michael Achenbach wrote: > nit: s/found at [here]/found [here] Done in https://codereview.chromium.org/2692443002 https://codereview.chromium.org/2688133002/diff/1/test/fuzzer/README.md#newco... test/fuzzer/README.md:17: 4) Now you can already compile the fuzzer with `ninja -j 1000 -C out/tmp/v8_simple_foo_fuzzer` On 2017/02/10 at 15:46:03, Michael Achenbach wrote: > nit: Maybe also add a gn call to populate out/tmp or use one of our canonical directlries, like x64.release? Done in https://codereview.chromium.org/2692443002 https://codereview.chromium.org/2688133002/diff/1/test/fuzzer/README.md#newco... test/fuzzer/README.md:20: * This build rule is needed to compile with gyp On 2017/02/10 at 15:46:03, Michael Achenbach wrote: > Regarding gyp deprecation: How about we abandon fuzzers in gyp? Nuke them from the gyp files and nuke the from the docu? I would support this idea, but are you sure that the gyp fuzzer builds are not used anywhere?
Message was sent while issue was closed.
https://codereview.chromium.org/2688133002/diff/1/test/fuzzer/README.md File test/fuzzer/README.md (right): https://codereview.chromium.org/2688133002/diff/1/test/fuzzer/README.md#newco... test/fuzzer/README.md:20: * This build rule is needed to compile with gyp On 2017/02/13 08:36:13, ahaas wrote: > On 2017/02/10 at 15:46:03, Michael Achenbach wrote: > > Regarding gyp deprecation: How about we abandon fuzzers in gyp? Nuke them from > the gyp files and nuke the from the docu? > > I would support this idea, but are you sure that the gyp fuzzer builds are not > used anywhere? No one could ever be sure. But we could try? But rather as an entirely separate action.
Message was sent while issue was closed.
https://codereview.chromium.org/2688133002/diff/1/test/fuzzer/README.md File test/fuzzer/README.md (right): https://codereview.chromium.org/2688133002/diff/1/test/fuzzer/README.md#newco... test/fuzzer/README.md:20: * This build rule is needed to compile with gyp On 2017/02/13 08:36:13, ahaas wrote: > On 2017/02/10 at 15:46:03, Michael Achenbach wrote: > > Regarding gyp deprecation: How about we abandon fuzzers in gyp? Nuke them from > the gyp files and nuke the from the docu? > > I would support this idea, but are you sure that the gyp fuzzer builds are not > used anywhere? No one could ever be sure. But we could try? But rather as an entirely separate action. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
