Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 268813003: PNaCl: Remove some more references to PNaCl+glibc in naclsdk.py (Closed)

Created:
5 years, 7 months ago by Mark Seaborn
Modified:
5 years, 7 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

PNaCl: Remove some more references to PNaCl+glibc in naclsdk.py Since env.Bit('nacl_glibc') is always False for PNaCl, we can inline uses of: * subroot * pnacl_lib * pnacl_extra_lib * pnacl_include BUG=https://code.google.com/p/nativeclient/issues/detail?id=3520 TEST=run scons R=jvoung@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13131

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -27 lines) Patch
M site_scons/site_tools/naclsdk.py View 2 chunks +3 lines, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Seaborn
5 years, 7 months ago (2014-05-02 19:57:25 UTC) #1
jvoung (off chromium)
lgtm
5 years, 7 months ago (2014-05-02 20:20:02 UTC) #2
Mark Seaborn
5 years, 7 months ago (2014-05-02 20:53:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r13131 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698