Issue 268813003: PNaCl: Remove some more references to PNaCl+glibc in naclsdk.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268813003: PNaCl: Remove some more references to PNaCl+glibc in naclsdk.py (Closed)

Created:
6 years, 7 months ago by Mark Seaborn

Modified:
6 years, 7 months ago

Reviewers:
jvoung (off chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client

Visibility:
Public.

More Reviews

Description

PNaCl: Remove some more references to PNaCl+glibc in naclsdk.py Since env.Bit('nacl_glibc') is always False for PNaCl, we can inline uses of: * subroot * pnacl_lib * pnacl_extra_lib * pnacl_include BUG=https://code.google.com/p/nativeclient/issues/detail?id=3520 TEST=run scons R=jvoung@chromium.org Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=13131

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -27 lines)			Patch
	M	site_scons/site_tools/naclsdk.py	View		2 chunks	+3 lines, -27 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Seaborn

6 years, 7 months ago (2014-05-02 20:53:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r13131 (presubmit successful).

Expand Messages | Collapse Messages