Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: site_scons/site_tools/naclsdk.py

Issue 268813003: PNaCl: Remove some more references to PNaCl+glibc in naclsdk.py (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: site_scons/site_tools/naclsdk.py
diff --git a/site_scons/site_tools/naclsdk.py b/site_scons/site_tools/naclsdk.py
index 66fc09ad22d3a0d3143ba4893538709d830c5595..10e779f4f87483c5ef5eae128c686b9e5a8eca25 100755
--- a/site_scons/site_tools/naclsdk.py
+++ b/site_scons/site_tools/naclsdk.py
@@ -174,34 +174,13 @@ def _SetEnvForPnacl(env, root):
else:
ld_arch_flag = arch_flag
- if env.Bit('nacl_glibc'):
- subroot = root + '/glibc'
- else:
- subroot = root
-
translator_root = os.path.join(os.path.dirname(root), 'pnacl_translator')
- binprefix = os.path.join(subroot, 'bin', 'pnacl-')
+ binprefix = os.path.join(root, 'bin', 'pnacl-')
binext = ''
if env.Bit('host_windows'):
binext = '.bat'
- if env.Bit('nacl_glibc'):
- # TODO(pdox): This bias is needed because runnable-ld is
- # expected to be in the same directory as the SDK.
- # This assumption should be removed.
- pnacl_lib = os.path.join(root, 'lib-%s' % arch)
- pnacl_extra_lib = os.path.join(subroot, 'lib')
- else:
- pnacl_lib = os.path.join(subroot, 'lib')
- pnacl_extra_lib = ''
-
- #TODO(robertm): remove NACL_SDK_INCLUDE ASAP
- if env.Bit('nacl_glibc'):
- pnacl_include = os.path.join(root, 'glibc', 'usr', 'include')
- else:
- pnacl_include = os.path.join(root, 'usr', 'include')
-
pnacl_ar = binprefix + 'ar' + binext
pnacl_as = binprefix + 'as' + binext
pnacl_nm = binprefix + 'nm' + binext
@@ -247,12 +226,9 @@ def _SetEnvForPnacl(env, root):
if env.Bit('x86_64_zero_based_sandbox'):
pnacl_translate_flags += ' -sfi-zero-based-sandbox'
- if pnacl_extra_lib:
- env.Prepend(LIBPATH=pnacl_extra_lib)
-
env.Replace(# Replace header and lib paths.
- NACL_SDK_INCLUDE=pnacl_include,
- NACL_SDK_LIB=pnacl_lib,
+ NACL_SDK_INCLUDE=os.path.join(root, 'usr', 'include'),
+ NACL_SDK_LIB=os.path.join(root, 'lib'),
# Remove arch-specific flags (if any)
BASE_LINKFLAGS='',
BASE_CFLAGS='',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698