Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2688123002: Mus Demo: Reorganize functions in mus_demo.cc (Closed)

Created:
3 years, 10 months ago by fwang
Modified:
3 years, 10 months ago
Reviewers:
rjkroege, tonikitoo
CC:
chromium-reviews, rjkroege, tonikitoo, kylechar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mus Demo: Reorganize functions in mus_demo.cc In [1], some functions were moved from the MusDemo class to the MusDemo::WindowTreeData class. Their bodies were however not moved inside mus_demo.cc (in order to facilitate review). This is now done in this CL and MusDemo::WindowTreeData member functions are grouped together at the same location. At the same time, the body of the constructor is actually moved to a separate Init function so that it can be used by another constructor in a follow-up CL. BUG=666958 R=rjkroege@chromium.org [1] https://codereview.chromium.org/2679213003/ Review-Url: https://codereview.chromium.org/2688123002 Cr-Commit-Position: refs/heads/master@{#449725} Committed: https://chromium.googlesource.com/chromium/src/+/c2a0b99030720bb2b0727cedb82f6debbc9a1f12

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -31 lines) Patch
M services/ui/demo/mus_demo.cc View 3 chunks +36 lines, -31 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
fwang
PTAL
3 years, 10 months ago (2017-02-10 10:28:12 UTC) #1
tonikitoo
informal l g t m
3 years, 10 months ago (2017-02-10 12:41:10 UTC) #5
rjkroege
lgtm
3 years, 10 months ago (2017-02-10 19:59:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688123002/1
3 years, 10 months ago (2017-02-10 20:36:59 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 20:43:49 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2a0b99030720bb2b0727cedb82f...

Powered by Google App Engine
This is Rietveld 408576698