Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2688093002: HeapCompact does not need to look up other threads' states (Closed)

Created:
3 years, 10 months ago by haraken
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), haraken, blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HeapCompact does not need to look up other threads' states Now that the per-thread heap is shipped, HeapCompact does not need to look up if other threads have pointers on their stacks. This CL removes that code. BUG=671856 Review-Url: https://codereview.chromium.org/2688093002 Cr-Commit-Position: refs/heads/master@{#449572} Committed: https://chromium.googlesource.com/chromium/src/+/6ac19e1710b6bdf828bc721d56c1f7ba8e48ff73

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M third_party/WebKit/Source/platform/heap/HeapCompact.cpp View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
haraken
PTAL
3 years, 10 months ago (2017-02-10 07:44:49 UTC) #2
sof
lgtm
3 years, 10 months ago (2017-02-10 07:52:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2688093002/1
3 years, 10 months ago (2017-02-10 07:55:16 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 09:30:25 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6ac19e1710b6bdf828bc721d56c1...

Powered by Google App Engine
This is Rietveld 408576698