Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2688033002:
Enable cc_unittests for tsan bot now that they pass. (Closed)
DescriptionEnable cc_unittests for tsan bot now that they pass.
R=gab@chromium.org
BUG=437454, 672860
Review-Url: https://codereview.chromium.org/2688033002
Cr-Commit-Position: refs/heads/master@{#449647}
Committed: https://chromium.googlesource.com/chromium/src/+/8f6e755711ae6d4d6640c409e462cdd048c7cfe8
Patch Set 1 #Patch Set 2 : enabletsan: rebase #Messages
Total messages: 20 (12 generated)
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
W00T, lgtm and good luck! Please add BUG 672860 to CL desc CC dpranke FYI Thanks, Gab
Description was changed from ========== Enable cc_unittests for tsan bot now that they pass. R=gab@chromium.org BUG=437454 ========== to ========== Enable cc_unittests for tsan bot now that they pass. R=gab@chromium.org BUG=437454, 672860 ==========
The CQ bit was unchecked by danakj@chromium.org
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
The CQ bit was checked by danakj@chromium.org
lgtm
The CQ bit was checked by danakj@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for testing/buildbot/chromium.memory.json:
While running git apply --index -p1;
error: patch failed: testing/buildbot/chromium.memory.json:595
error: testing/buildbot/chromium.memory.json: patch does not apply
Patch: testing/buildbot/chromium.memory.json
Index: testing/buildbot/chromium.memory.json
diff --git a/testing/buildbot/chromium.memory.json
b/testing/buildbot/chromium.memory.json
index
3aa126bf70ff8124b5c6ff15395a4216378a3693..e7769263251510ba93e6bb36e84fd8c59cecbca4
100644
--- a/testing/buildbot/chromium.memory.json
+++ b/testing/buildbot/chromium.memory.json
@@ -595,7 +595,6 @@
"disabled_tests": {
"app_shell_browsertests": "http://crbug.com/455633",
"browser_tests": "Too many errors, clean content_browsertests first.
http://crbug.com/368525",
- "cc_unittests": "http://crbug.com/437454",
"interactive_ui_tests": "http://crbug.com/455679"
},
"gtest_tests": [
@@ -639,6 +638,12 @@
"swarming": {
"can_use_on_swarming_builders": true
},
+ "test": "cc_unittests"
+ },
+ {
+ "swarming": {
+ "can_use_on_swarming_builders": true
+ },
"test": "chromedriver_unittests"
},
{
Well, the tests passed :3
The CQ bit was checked by danakj@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, gab@chromium.org Link to the patchset: https://codereview.chromium.org/2688033002/#ps20001 (title: "enabletsan: rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486743216817800,
"parent_rev": "4c5ade43823c4f265f6960e5581414f685dcb0d4", "commit_rev":
"8f6e755711ae6d4d6640c409e462cdd048c7cfe8"}
Message was sent while issue was closed.
Description was changed from ========== Enable cc_unittests for tsan bot now that they pass. R=gab@chromium.org BUG=437454, 672860 ========== to ========== Enable cc_unittests for tsan bot now that they pass. R=gab@chromium.org BUG=437454, 672860 Review-Url: https://codereview.chromium.org/2688033002 Cr-Commit-Position: refs/heads/master@{#449647} Committed: https://chromium.googlesource.com/chromium/src/+/8f6e755711ae6d4d6640c409e462... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8f6e755711ae6d4d6640c409e462... |
