Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issue 2687973002: Move parallelDownloading feature to content/ (Closed)

Created:
3 years, 10 months ago by qinmin
Modified:
3 years, 10 months ago
Reviewers:
alexmos
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move parallDownloading feature to content/ This feature should not be dependant on the embedder. Additionally, most of the download code rest in content/browser/. Move the feature from chrome/ to content/ BUG=644352 Review-Url: https://codereview.chromium.org/2687973002 Cr-Commit-Position: refs/heads/master@{#449423} Committed: https://chromium.googlesource.com/chromium/src/+/bfb00e35e0d1cff74c3b402029fb5310c95bed7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M chrome/common/chrome_features.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M content/public/common/content_features.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_features.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
qinmin
Alex, would you please take a quick look at this tiny change? Thanks
3 years, 10 months ago (2017-02-09 19:13:12 UTC) #2
alexmos
LGTM. Nit in subject/description: parallDownloading -> parallelDownloading
3 years, 10 months ago (2017-02-09 19:35:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687973002/1
3 years, 10 months ago (2017-02-09 19:37:27 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 21:43:36 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bfb00e35e0d1cff74c3b402029fb...

Powered by Google App Engine
This is Rietveld 408576698