Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2687953002: Update code for generating osc sweep reference files (Closed)

Created:
3 years, 10 months ago by Raymond Toy
Modified:
3 years, 10 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update code for generating osc sweep reference files Update instruction and code on how to generate the reference files for the oscillator sweep tests. Manually extracted the code to its own file and ran the test to generate a swept sine wave. Output is generated and audibly sounds correct. BUG=689689 TEST= Review-Url: https://codereview.chromium.org/2687953002 Cr-Commit-Position: refs/heads/master@{#449462} Committed: https://chromium.googlesource.com/chromium/src/+/f5f830019d57e4405d74568dde8989b5cc7661c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -8 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/resources/oscillator-testing.js View 1 chunk +6 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 10 months ago (2017-02-09 18:57:14 UTC) #2
hongchan
lgtm
3 years, 10 months ago (2017-02-09 21:56:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687953002/1
3 years, 10 months ago (2017-02-09 22:13:27 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 23:27:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5f830019d57e4405d74568dde89...

Powered by Google App Engine
This is Rietveld 408576698