Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp

Issue 2687943004: Abstract out ThreadDebugger from V8PerIsolateData (Closed)
Patch Set: Initialize HiddenValue and PrivateProperty in V8Initializer Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp b/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
index 6fb752a8ecc45eb63304e56e06ecdc5374f6a05d..fa71d17e21b23299e57d04457312fcb23ad454f1 100644
--- a/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp
@@ -4,6 +4,7 @@
#include "core/workers/WorkerBackingThread.h"
+#include <memory>
#include "bindings/core/v8/V8Binding.h"
#include "bindings/core/v8/V8GCController.h"
#include "bindings/core/v8/V8IdleTaskRunner.h"
@@ -16,7 +17,6 @@
#include "public/platform/Platform.h"
#include "public/platform/WebTraceLocation.h"
#include "wtf/PtrUtil.h"
-#include <memory>
namespace blink {
@@ -80,8 +80,8 @@ void WorkerBackingThread::initialize() {
if (m_isOwningThread)
Platform::current()->didStartWorkerThread();
- V8PerIsolateData::from(m_isolate)->setThreadDebugger(
- WTF::makeUnique<WorkerThreadDebugger>(m_isolate));
+ ThreadDebugger::setThreadDebugger(m_isolate,
jbroman 2017/02/15 02:25:24 Kinda weird for the setter to go through ThreadDeb
adithyas 2017/02/15 18:12:12 I thought it would be better to pair the getter an
+ new WorkerThreadDebugger(m_isolate));
}
void WorkerBackingThread::shutdown() {

Powered by Google App Engine
This is Rietveld 408576698