Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp

Issue 2687943004: Abstract out ThreadDebugger from V8PerIsolateData (Closed)
Patch Set: Initialize HiddenValue and PrivateProperty in V8Initializer Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
diff --git a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
index 99b1690d2b7ab6de80d788b1ae88c31680dacccb..c219a0cadac0c556a5396859a7ce616bf60c81ea 100644
--- a/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
+++ b/third_party/WebKit/Source/core/inspector/WorkerThreadDebugger.cpp
@@ -56,11 +56,11 @@ const int kInvalidContextGroupId = 0;
} // namespace
WorkerThreadDebugger* WorkerThreadDebugger::from(v8::Isolate* isolate) {
- V8PerIsolateData* data = V8PerIsolateData::from(isolate);
- if (!data->threadDebugger())
+ ThreadDebugger* debugger = ThreadDebugger::getThreadDebugger(isolate);
jbroman 2017/02/15 02:25:24 Should be able to use ThreadDebugger::from here.
+ if (!debugger)
return nullptr;
- ASSERT(data->threadDebugger()->isWorker());
- return static_cast<WorkerThreadDebugger*>(data->threadDebugger());
+ CHECK(debugger->isWorker());
jbroman 2017/02/15 02:25:23 ASSERT -> DCHECK, not CHECK
adithyas 2017/02/15 18:12:12 Fixed, thanks!
+ return static_cast<WorkerThreadDebugger*>(debugger);
}
WorkerThreadDebugger::WorkerThreadDebugger(v8::Isolate* isolate)

Powered by Google App Engine
This is Rietveld 408576698