Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Issue 2687933005: HTMLVideoElement: add metrics for poster attribute usage. (Closed)

Created:
3 years, 10 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 10 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, Srirama
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HTMLVideoElement: add metrics for poster attribute usage. BUG=692004 Review-Url: https://codereview.chromium.org/2687933005 Cr-Commit-Position: refs/heads/master@{#450351} Committed: https://chromium.googlesource.com/chromium/src/+/a62a2c95a18cbb75dadb1c95744a5082c22a704e

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLVideoElement.idl View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
mlamouri (slow - plz ping)
jochen@, PTAL at this very complex boilerplate :)
3 years, 10 months ago (2017-02-11 15:14:26 UTC) #2
jochen (gone - plz use gerrit)
lgtm
3 years, 10 months ago (2017-02-14 09:03:19 UTC) #7
mlamouri (slow - plz ping)
Sending to CQ, hoping it still applies :)
3 years, 10 months ago (2017-02-14 09:51:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687933005/20001
3 years, 10 months ago (2017-02-14 09:51:42 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/152992)
3 years, 10 months ago (2017-02-14 09:53:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687933005/40001
3 years, 10 months ago (2017-02-14 11:30:42 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/38441)
3 years, 10 months ago (2017-02-14 11:39:54 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687933005/40001
3 years, 10 months ago (2017-02-14 14:33:52 UTC) #20
commit-bot: I haz the power
3 years, 10 months ago (2017-02-14 15:05:04 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a62a2c95a18cbb75dadb1c95744a...

Powered by Google App Engine
This is Rietveld 408576698