Dashboard - Clicking revisions leads to group_reports.

Dashboard - Clicking revisions leads to group_reports.

Demo: https://dev-simonhatch-90a2bc92-dot-chromeperf.appspot.com/alerts

BUG=catapult:#2269

Review-Url: https://codereview.chromium.org/2687933002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f25bfea25223277cb04abf0eef039f35f280c987

[shatch, 2017-02-09 18:26:29]

Description was changed from

==========
Dashboard - Clicking revisions leads to group_reports.

BUG=catapult:#2269
==========

to

==========
Dashboard - Clicking revisions leads to group_reports.

https://dev-simonhatch-90a2bc92-dot-chromeperf.appspot.com/alerts

BUG=catapult:#2269
==========

[shatch, 2017-02-09 18:26:45]

Description was changed from

==========
Dashboard - Clicking revisions leads to group_reports.

https://dev-simonhatch-90a2bc92-dot-chromeperf.appspot.com/alerts

BUG=catapult:#2269
==========

to

==========
Dashboard - Clicking revisions leads to group_reports.

Demo: https://dev-simonhatch-90a2bc92-dot-chromeperf.appspot.com/alerts

BUG=catapult:#2269
==========

[shatch, 2017-02-09 18:26:45]

simonhatch@chromium.org changed reviewers:
+ hablich@chromium.org, sullivan@chromium.org

[shatch, 2017-02-09 18:30:28]

So the revision link and the "Graph" button both bring you to the same
/group_report page. One weird thing is that the trending arrow link brings you
to a different page (/report), not sure if that's more confusing with both links
side by side now.

[sullivan, 2017-02-09 18:36:53]

On 2017/02/09 18:30:28, shatch wrote:
> So the revision link and the "Graph" button both bring you to the same
> /group_report page. One weird thing is that the trending arrow link brings you
> to a different page (/report), not sure if that's more confusing with both
links
> side by side now.

Yeah, it is a little confusing to have the two similar-but-not-the-same links
together. I think the big problem is that a lot of people don't know the
differences between /report and /group_report.

If this is a big help to v8 team, maybe start with submitting this and see what
feedback we get?

lgtm

[shatch, 2017-02-09 18:47:24]

On 2017/02/09 18:36:53, sullivan wrote:
> On 2017/02/09 18:30:28, shatch wrote:
> > So the revision link and the "Graph" button both bring you to the same
> > /group_report page. One weird thing is that the trending arrow link brings
you
> > to a different page (/report), not sure if that's more confusing with both
> links
> > side by side now.
> 
> Yeah, it is a little confusing to have the two similar-but-not-the-same links
> together. I think the big problem is that a lot of people don't know the
> differences between /report and /group_report.
> 
> If this is a big help to v8 team, maybe start with submitting this and see
what
> feedback we get?
> 
> lgtm

sgtm

[shatch, 2017-02-09 18:47:27]

The CQ bit was checked by simonhatch@chromium.org

[commit-bot: I haz the power, 2017-02-09 18:47:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 19:08:46]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486666047693940, "parent_rev":
"af506e4c993f7372ac30fa8e8a454d2a8cceca2f", "commit_rev":
"f25bfea25223277cb04abf0eef039f35f280c987"}

[commit-bot: I haz the power, 2017-02-09 19:08:49]

Description was changed from

==========
Dashboard - Clicking revisions leads to group_reports.

Demo: https://dev-simonhatch-90a2bc92-dot-chromeperf.appspot.com/alerts

BUG=catapult:#2269
==========

to

==========
Dashboard - Clicking revisions leads to group_reports.

Demo: https://dev-simonhatch-90a2bc92-dot-chromeperf.appspot.com/alerts

BUG=catapult:#2269

Review-Url: https://codereview.chromium.org/2687933002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-02-09 19:08:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[Michael Hablich, 2017-02-09 19:18:08]

On 2017/02/09 at 19:08:51, commit-bot wrote:
> Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Good catch. I never click the arrow icon because of missing group feature. I
could ask around though.

For me it is logical that the graph shows me the single alert and the revision
link all alerts for the range.

[Michael Hablich, 2017-02-09 19:18:46]

lgtm

[shatch, 2017-02-09 19:20:47]

On 2017/02/09 19:18:08, Michael Hablich wrote:
> On 2017/02/09 at 19:08:51, commit-bot wrote:
> > Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
> 
> Good catch. I never click the arrow icon because of missing group feature. I
> could ask around though.
> 
> For me it is logical that the graph shows me the single alert and the revision
> link all alerts for the range.

Yeah I never click that arrow either, maybe it would be good eventually to get a
sense of how many sheriffs actually use it and potentially remove it.

[Michael Hablich, 2017-02-09 20:34:25]

On 2017/02/09 at 19:20:47, simonhatch wrote:
> On 2017/02/09 19:18:08, Michael Hablich wrote:
> > On 2017/02/09 at 19:08:51, commit-bot wrote:
> > > Committed patchset #1 (id:1) as
> >
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
> > 
> > Good catch. I never click the arrow icon because of missing group feature. I
> > could ask around though.
> > 
> > For me it is logical that the graph shows me the single alert and the
revision
> > link all alerts for the range.
> 
> Yeah I never click that arrow either, maybe it would be good eventually to get
a sense of how many sheriffs actually use it and potentially remove it.

Hooking up Analytics tracking it should be possible I think.