Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2687933002: Dashboard - Clicking revisions leads to group_reports. (Closed)

Created:
3 years, 10 months ago by shatch
Modified:
3 years, 10 months ago
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M dashboard/dashboard/elements/alerts-table.html View 1 chunk +1 line, -1 line 0 comments Download
M dashboard/dashboard/elements/revision-range.html View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
shatch
So the revision link and the "Graph" button both bring you to the same /group_report ...
3 years, 10 months ago (2017-02-09 18:30:28 UTC) #4
sullivan
On 2017/02/09 18:30:28, shatch wrote: > So the revision link and the "Graph" button both ...
3 years, 10 months ago (2017-02-09 18:36:53 UTC) #5
shatch
On 2017/02/09 18:36:53, sullivan wrote: > On 2017/02/09 18:30:28, shatch wrote: > > So the ...
3 years, 10 months ago (2017-02-09 18:47:24 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687933002/1
3 years, 10 months ago (2017-02-09 18:47:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f25bfea25223277cb04abf0eef039f35f280c987
3 years, 10 months ago (2017-02-09 19:08:51 UTC) #11
Michael Hablich
On 2017/02/09 at 19:08:51, commit-bot wrote: > Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f25bfea25223277cb04abf0eef039f35f280c987 Good catch. ...
3 years, 10 months ago (2017-02-09 19:18:08 UTC) #12
Michael Hablich
lgtm
3 years, 10 months ago (2017-02-09 19:18:46 UTC) #13
shatch
On 2017/02/09 19:18:08, Michael Hablich wrote: > On 2017/02/09 at 19:08:51, commit-bot wrote: > > ...
3 years, 10 months ago (2017-02-09 19:20:47 UTC) #14
Michael Hablich
3 years, 10 months ago (2017-02-09 20:34:25 UTC) #15
Message was sent while issue was closed.
On 2017/02/09 at 19:20:47, simonhatch wrote:
> On 2017/02/09 19:18:08, Michael Hablich wrote:
> > On 2017/02/09 at 19:08:51, commit-bot wrote:
> > > Committed patchset #1 (id:1) as
> >
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
> > 
> > Good catch. I never click the arrow icon because of missing group feature. I
> > could ask around though.
> > 
> > For me it is logical that the graph shows me the single alert and the
revision
> > link all alerts for the range.
> 
> Yeah I never click that arrow either, maybe it would be good eventually to get
a sense of how many sheriffs actually use it and potentially remove it.

Hooking up Analytics tracking it should be possible I think.

Powered by Google App Engine
This is Rietveld 408576698