Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 2687913002: [ObjC ARC] Converts ios/chrome/browser/ui/main:unit_tests to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/main:unit_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2687913002 Cr-Commit-Position: refs/heads/master@{#449626} Committed: https://chromium.googlesource.com/chromium/src/+/3f4b6916825e40fad40efdf2b28a6c29776a2607

Patch Set 1 #

Total comments: 1

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -39 lines) Patch
M ios/chrome/browser/ui/main/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/main/browser_view_wrangler_unittest.mm View 2 chunks +7 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/main/main_coordinator_unittest.mm View 1 chunk +7 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/main/main_view_controller_unittest.mm View 1 4 chunks +26 lines, -30 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
lody
Please review, thanks
3 years, 10 months ago (2017-02-10 09:07:22 UTC) #6
marq (ping after 24h)
lgtm https://codereview.chromium.org/2687913002/diff/1/ios/chrome/browser/ui/main/main_view_controller_unittest.mm File ios/chrome/browser/ui/main/main_view_controller_unittest.mm (right): https://codereview.chromium.org/2687913002/diff/1/ios/chrome/browser/ui/main/main_view_controller_unittest.mm#newcode26 ios/chrome/browser/ui/main/main_view_controller_unittest.mm:26: @property(weak, nonatomic, readonly) id didMoveToParentViewControllerArgument; Nit: Prefer to ...
3 years, 10 months ago (2017-02-10 11:02:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687913002/20001
3 years, 10 months ago (2017-02-10 14:40:58 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 15:53:17 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3f4b6916825e40fad40efdf2b28a...

Powered by Google App Engine
This is Rietveld 408576698